Add behaviors to cache rather than muddying the Get function #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
peterbroadhurst
commented
Jun 29, 2023
| @@ -32,7 +32,6 @@ linters: | |||
| disable-all: false | |||
| enable: | |||
| - bodyclose | |||
| - depguard | |||
There was a problem hiding this comment.
This was suddenly firing for me
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Chengxuan
reviewed
Jun 29, 2023
| time.Sleep(1 * time.Millisecond) | ||
| } | ||
|
|
||
| assert.NotNil(t, cache1.GetUnexpired("test")) | ||
| assert.NotNil(t, cache1.Get("test")) |
There was a problem hiding this comment.
@peterbroadhurst can we also add a test to demonstrate how TTL works for ttlFromInitialAdd mode?
There was a problem hiding this comment.
dumb question, ignore that
Chengxuan
approved these changes
Jun 29, 2023
This was referenced Jun 29, 2023
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.