-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow any string for ID column, and support collections without an updated
column
#71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Codecov Report
@@ Coverage Diff @@
## main #71 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 63 63
Lines 4654 4778 +124
==========================================
+ Hits 4654 4778 +124
|
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
adding support for groupby
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Provide alternative operation mode for cache for code users
Provide alternative operation mode for cache for code users
awrichar
reviewed
Jun 28, 2023
awrichar
reviewed
Jun 28, 2023
awrichar
approved these changes
Jun 29, 2023
Closed
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Add behaviors to cache rather than muddying the Get function
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple of updates/enhancements found to be required while working on FFTM/EVMConnect:
ResourceBase
still uses fftypes.UUIDnamesace:UUID
convention from FF Core (established historically)updated
columncreated
/updated
columns to any fields in your business object, but required them. This was a pain for write-or-delete-only data, which is true for performance sensitive transaction history records in FFTM/EVMConnectnonce
sorting, but will have benefits in other places in the FireFly ecosystem. For example in Core it will be possible to sort account balances etc.DeleteMany
operation to CRUDCount
operation to CRUDseq
column in flexible waysAND
optionally, rather thanOR
as is the default[
modifier forAND
modifier, and and]
forOR
allowing you to do:?created=[>12345&created=[<23456
-AND
?created=[]>12345&created=[]<23456
-OR
(explicit - because second modifier overrides first)?created=]>12345&created=]<23456
-OR
(explicit)?created=>12345&created=<23456
-OR
(implicit)