DCO Check GitHub workflow #7179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usmansaleem
reviewed
Jun 5, 2024
There was a problem hiding this comment.
the dco workflow failed because its not in the list of "allowed" workflow actions. https://github.com/hyperledger/besu/actions/runs/9378991548
macfarla
approved these changes
Jun 5, 2024
How can we request to allow the action? |
jflo
approved these changes
Jun 5, 2024
DCO App not working and needed to be disabled the check. Introducing DCO GitHub action workflow to validate the commit signatures. Closes #7175 Signed-off-by: Chaminda Divitotawela <cdivitotawela@gmail.com> Signed-off-by: Ry Jones <ry@linux.com>
|
DCO is working now. |
seanyoung
added a commit
to seanyoung/solang
that referenced
this pull request
Jun 5, 2024
See hyperledger/besu#7179 Signed-off-by: Sean Young <sean@mess.org>
gtebrean
pushed a commit
to gtebrean/besu
that referenced
this pull request
Jun 26, 2024
DCO App not working and needed to be disabled the check. Introducing DCO GitHub action workflow to validate the commit signatures. Closes hyperledger#7175 Signed-off-by: Chaminda Divitotawela <cdivitotawela@gmail.com> Signed-off-by: Ry Jones <ry@linux.com> Signed-off-by: George Tebrean <george@web3labs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
DCO App not working and needed to be disabled the check. Introducing DCO GitHub action workflow to validate the commit signatures.
Fixed Issue(s)
fixes #7175
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests