fix: RFC JSON formatting #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Ebert <jamesebert.k@gmail.com>
Signed-off-by: James Ebert <jamesebert.k@gmail.com>
swcurran
approved these changes
Jun 5, 2024
|
I manually verified that the DCO is correct, despite the hung check. @ryjones — should we plan on going ahead with merges while the DCO check is stuck based on manual checking? What is the impact if we mistakenly think the DCO is correct and it is not? |
|
@swcurran you should add this file in all of your repos |
|
@JamesKEbert could you push some other commit to trigger the running of the DCO check? It should go then... |
Signed-off-by: James Ebert <jamesebert.k@gmail.com>
|
Done 👍 |
swcurran
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of RFCs' JSON examples don't display properly in deployed site, so I ran a formatter over it to resolve the issues (the ```json= is the primary problem). The issue can be observed here: https://hyperledger.github.io/aries-rfcs/latest/features/0685-pickup-v2/#reference
Also updates RFC 0496 to be in ADOPTED category in mkdocs/index (#834)