Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] - Vertx and Netty minor version bumps #7156

Merged
merged 9 commits into from
May 31, 2024
Merged

[MINOR] - Vertx and Netty minor version bumps #7156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9cd5abd
Bump vertx and netty minor versions
Gabriel-Trintinalia May 30, 2024
ae8595d
Merge branch 'main' into bump-vertx-netty
Gabriel-Trintinalia May 30, 2024
9217506
Remove 104 entries
Gabriel-Trintinalia May 30, 2024
290129b
Update to latest version
Gabriel-Trintinalia May 30, 2024
3e824b8
Merge branch 'bump-vertx-netty' of https://github.com/Gabriel-Trintin…
Gabriel-Trintinalia May 30, 2024
ac4ef00
Remove unused
Gabriel-Trintinalia May 30, 2024
ea8b704
Change error code when invalid request
Gabriel-Trintinalia May 30, 2024
e8a2f15
Merge branch 'main' into bump-vertx-netty
Gabriel-Trintinalia May 30, 2024
f233253
Merge branch 'main' into bump-vertx-netty
Gabriel-Trintinalia May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...t/java/org/hyperledger/besu/ethereum/api/graphql/GraphQLHttpServiceHostWhitelistTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,8 @@ private int doRequest(final String hostname) throws IOException {
@Test
public void requestWithMalformedHostIsRejected() throws IOException {
graphQLConfig.setHostsAllowlist(hostsWhitelist);
Assertions.assertThat(doRequest("ally:friend")).isEqualTo(403);
Assertions.assertThat(doRequest("ally:123456")).isEqualTo(403);
Assertions.assertThat(doRequest("ally:friend:1234")).isEqualTo(403);
Assertions.assertThat(doRequest("ally:friend")).isEqualTo(400);
Assertions.assertThat(doRequest("ally:123456")).isEqualTo(400);
Assertions.assertThat(doRequest("ally:friend:1234")).isEqualTo(400);
}
}
6 changes: 3 additions & 3 deletions ...t/java/org/hyperledger/besu/ethereum/api/jsonrpc/JsonRpcHttpServiceHostAllowlistTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,8 +206,8 @@ private int doRequest(final String hostname) throws IOException {
@Test
public void requestWithMalformedHostIsRejected() throws IOException {
jsonRpcConfig.setHostsAllowlist(hostsAllowlist);
assertThat(doRequest("ally:friend")).isEqualTo(403);
assertThat(doRequest("ally:123456")).isEqualTo(403);
assertThat(doRequest("ally:friend:1234")).isEqualTo(403);
assertThat(doRequest("ally:friend")).isEqualTo(400);
assertThat(doRequest("ally:123456")).isEqualTo(400);
assertThat(doRequest("ally:friend:1234")).isEqualTo(400);
}
}
6 changes: 3 additions & 3 deletions .../java/org/hyperledger/besu/ethereum/api/jsonrpc/websocket/WebSocketHostAllowlistTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,9 +196,9 @@ public void websocketRequestWithMalformedHostIsRejected(final String hostname) {
public void httpRequestWithMalformedHostIsRejected() throws Throwable {
webSocketConfiguration.setAuthenticationEnabled(false);
webSocketConfiguration.setHostsAllowlist(hostsAllowlist);
doHttpRequestAndVerify(testContext, "ally:friend", 403);
doHttpRequestAndVerify(testContext, "ally:123456", 403);
doHttpRequestAndVerify(testContext, "ally:friend:1234", 403);
doHttpRequestAndVerify(testContext, "ally:friend", 400);
doHttpRequestAndVerify(testContext, "ally:123456", 400);
doHttpRequestAndVerify(testContext, "ally:friend:1234", 400);
}

private void doHttpRequestAndVerify(
Expand Down
Loading
Loading