Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] - Vertx and Netty minor version bumps #7156

Merged

Conversation

Gabriel-Trintinalia
Copy link
Contributor

@Gabriel-Trintinalia Gabriel-Trintinalia commented May 30, 2024

PR Description

Updated dependencies:

  • Vert.x: 4.5.4 -> 4.5.8
  • Netty: 4.1.104.Final -> 4.1.110.Final

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Copy link
Contributor

@pinges pinges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see a lot of the old version (104) and even (100). Please check these.

<artifact name="netty-handler-4.1.107.Final.pom">
<sha256 value="c6c59fd6f0f70a043a50a5826de7ad68dbb95d341e03bd1bbe179038e48b845e" origin="Generated by Gradle"/>
<artifact name="netty-handler-4.1.108.Final.pom">
<sha256 value="e621cafa98907ed01e8a713ff4aaa650943591b023b4f6ee249e4deb9f8d566f" origin="Generated by Gradle"/>
</artifact>
</component>
<component group="io.netty" name="netty-handler-proxy" version="4.1.100.Final">
<artifact name="netty-handler-proxy-4.1.100.Final.pom">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should that be 4.1.108 as well?

<artifact name="netty-handler-ssl-ocsp-4.1.104.Final.pom">
<sha256 value="aee924520525966b3481ebfee6ee95c3a206d23f07f69270557a9dd2f73dead6" origin="Generated by Gradle"/>
<artifact name="netty-handler-ssl-ocsp-4.1.108.Final.pom">
<sha256 value="f65a5d25178de89e666e69350251561988b1593bd4a5e867783f734efe04be13" origin="Generated by Gradle"/>
</artifact>
</component>
<component group="io.netty" name="netty-parent" version="4.1.100.Final">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s.a.

<artifact name="netty-resolver-dns-classes-macos-4.1.104.Final.pom">
<sha256 value="cc6a0c226b1fce0fc56674bc0c021b6512379025bb0cb0608be6a38e370dcd4f" origin="Generated by Gradle"/>
<artifact name="netty-resolver-dns-classes-macos-4.1.108.Final.pom">
<sha256 value="682a939501e89108d4a7ec45dc2962b853da00127dfb07542de966ab50839782" origin="Generated by Gradle"/>
</artifact>
</component>
<component group="io.netty" name="netty-resolver-dns-native-macos" version="4.1.104.Final">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s.a.

<artifact name="netty-transport-4.1.108.Final.pom">
<sha256 value="453e9a0de74529d0551e53eca11c91d561c55e1665ae40637193b84567692cd6" origin="Generated by Gradle"/>
</artifact>
</component>
<component group="io.netty" name="netty-transport-classes-epoll" version="4.1.104.Final">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s.a.

<artifact name="netty-transport-4.1.108.Final.pom">
<sha256 value="453e9a0de74529d0551e53eca11c91d561c55e1665ae40637193b84567692cd6" origin="Generated by Gradle"/>
</artifact>
</component>
<component group="io.netty" name="netty-transport-classes-epoll" version="4.1.104.Final">
<artifact name="netty-transport-classes-epoll-4.1.104.Final.jar">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s.a.

<artifact name="netty-transport-classes-epoll-4.1.108.Final.pom">
<sha256 value="404ae90fb49e933b4bcd9d892fb7f9073329645b36c9d469929e4da5f1dc61ab" origin="Generated by Gradle"/>
</artifact>
</component>
<component group="io.netty" name="netty-transport-classes-kqueue" version="4.1.104.Final">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s.a.

<artifact name="netty-transport-classes-kqueue-4.1.108.Final.pom">
<sha256 value="488f3d56a04f76fd832330486969575d29410fa2c30c6e1dbca5187ef47360c7" origin="Generated by Gradle"/>
</artifact>
</component>
<component group="io.netty" name="netty-transport-native-epoll" version="4.1.104.Final">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s.a.

<artifact name="netty-transport-native-epoll-4.1.108.Final.pom">
<sha256 value="382db1962bfaf99339bdfe2dfb8daa2cdfe32c16a589680ef1527ffdbe53de36" origin="Generated by Gradle"/>
</artifact>
</component>
<component group="io.netty" name="netty-transport-native-kqueue" version="4.1.104.Final">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s.a.

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
gradle/versions.gradle Outdated Show resolved Hide resolved
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@Gabriel-Trintinalia Gabriel-Trintinalia marked this pull request as draft May 30, 2024 04:33
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@Gabriel-Trintinalia Gabriel-Trintinalia marked this pull request as ready for review May 30, 2024 23:28
Copy link
Contributor

@pinges pinges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gabriel-Trintinalia Gabriel-Trintinalia enabled auto-merge (squash) May 30, 2024 23:33
@Gabriel-Trintinalia Gabriel-Trintinalia enabled auto-merge (squash) May 31, 2024 04:14
@Gabriel-Trintinalia Gabriel-Trintinalia merged commit 6f3650f into hyperledger:main May 31, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants