-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: encryption envelope APIs, tests #1082
Conversation
5480f3d
to
b33c40e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1082 +/- ##
========================================
- Coverage 0.05% 0.05% -0.01%
========================================
Files 471 471
Lines 24019 24093 +74
Branches 4295 4332 +37
========================================
Hits 13 13
- Misses 24005 24079 +74
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Just a couple of nitpicks , looks ok to me. |
Needs a rebase 🥲 |
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
5fc1905
to
a00160a
Compare
@xprazak2 rebased |
Thanks! |
EncryptionEnvelope
EncryptionEnvelope
by decoupling its APIs from concept of Aries messages. Even inherentlydidcomm !== aries
, so this decoupling makes broader sense and also makes testing a lot easier.AriesDidDoc
structure in encryption envelope