Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: didcomm message forwarding #1081

Merged
merged 2 commits into from
Dec 7, 2023
Merged

fix: didcomm message forwarding #1081

merged 2 commits into from
Dec 7, 2023

Conversation

Patrik-Stas
Copy link
Contributor

  • Previous refactoring PR refactor: encryption envelope #1070 introduced an error such that to field in the forward message ended up string containing JSON array ("to": "[\"foobar\"]"), rather than correctly just the key ("to": "foobar")
  • This PR fixes the issue
  • The issue was detected as mediator tests started to fail
  • This PR is to be followed by another PR restoring encryption envelope tests

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas Patrik-Stas added the review:level-1 At least 1 approval required for merge label Dec 5, 2023
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas Patrik-Stas changed the title Fix encryption envelope fix: encryption envelope Dec 5, 2023
@Patrik-Stas Patrik-Stas changed the title fix: encryption envelope fix: encryption envelope message forwarding Dec 5, 2023
@Patrik-Stas Patrik-Stas changed the title fix: encryption envelope message forwarding fix: didcomm message forwarding Dec 5, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (5a42a2a) 0.05% compared to head (3a2da3d) 0.05%.

Files Patch % Lines
aries/aries_vcx/src/utils/encryption_envelope.rs 0.00% 13 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1081      +/-   ##
========================================
- Coverage   0.05%   0.05%   -0.01%     
========================================
  Files        471     471              
  Lines      24015   24019       +4     
  Branches    4292    4295       +3     
========================================
  Hits          13      13              
- Misses     24001   24005       +4     
  Partials       1       1              
Flag Coverage Δ
unittests-aries-vcx 0.05% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Patrik-Stas Patrik-Stas requested a review from xprazak2 December 5, 2023 21:11
@xprazak2 xprazak2 merged commit a7bac93 into main Dec 7, 2023
28 checks passed
@xprazak2 xprazak2 deleted the fix/encryption-envelope branch December 7, 2023 12:44
@xprazak2
Copy link
Contributor

xprazak2 commented Dec 7, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:level-1 At least 1 approval required for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants