Split test code #1023
Merged
Split test code #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36b6e9e to
58bd477
Compare
Codecov Report
@@ Coverage Diff @@
## main #1023 +/- ##
==========================================
- Coverage 36.31% 0.11% -36.20%
==========================================
Files 386 383 -3
Lines 22040 21284 -756
Branches 4063 3837 -226
==========================================
- Hits 8003 25 -7978
- Misses 11877 21254 +9377
+ Partials 2160 5 -2155
Flags with carried forward coverage won't be shown. Click here to find out more.
|
3a4c426 to
c519dce
Compare
Patrik-Stas
previously approved these changes
Oct 25, 2023
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
372457d to
dc0e5d8
Compare
Patrik-Stas
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt at a better separation between test and production code. This comes with the removal of default features from
aries_vcxand the introduction of thetest_utilsand thelibvcx_loggercrates.Some
run_setup_testmacro changes were pulled from #1022 for simplicity (since this PR heavily modifies and moves test code).NOTE:
uniffi_aries_vcxandrust/mediatorcrates usetest_utilsas a full dependency (not dev) because of theMockLedgerrequirement. While a dummy implementor ofLedgerReadand LedgerWrite` parts could be implemented, this part of the crates seems to be in need of updating anyway, so for simplicity this compromise was done.