-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add backtrace capturing, prototype a test err handling #1022
Conversation
72dc7ec
to
4750b50
Compare
Codecov Report
@@ Coverage Diff @@
## main #1022 +/- ##
======================================
Coverage 0.05% 0.05%
======================================
Files 384 384
Lines 21249 21084 -165
Branches 3821 3910 +89
======================================
Hits 12 12
+ Misses 21236 21071 -165
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@Patrik-Stas Please note that as part of #1023 I actually copied the |
c712666
to
c914a37
Compare
None, really. Just convenience.
I assume it could be removed in this case, indeed. |
d9898ab
to
285fbfd
Compare
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
285fbfd
to
c72360c
Compare
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
This should be ready for re-review.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
run(fn)
test case wraps as they turned out to be no longer necessary. Deleted related dead code.backtrace_errors
; when enabled,backtrace
dependency is included and error thrown from aries-vcx contain capture backtrace informationDisplay
impl forAriesVcxError
Debug
impl forAriesVcxError
- this is useful when err is thrown from a test run by cargo test runner-> Result<(), Box<dyn Error>>
instead of-> ()
.unwrap()
unwrap()
panics was that that they included stacktrace, which is not default with returning an error - but with additions mentioned above, we are not loosing this capabilityIf agreed, we can continue adopting:
After rebase
I've temporarily addedrun2
but I want to question 2 things:What's the purpose of macrorun_setup_test(...)
as opposed to just callingbuild_setup_profile().await.run(...)
I believe that whole run thingpub async fn run<F>(self, f: impl FnOnce(Self) -> F)
is now obsolete, there's no universal setup&cleanup which is valid for every test. In fact,run
is not doing anything useful atm, other the running the test itself