-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: pulled in original sources #2
chore: pulled in original sources #2
Conversation
Contains the code donated by Accenture as part of the lab Commit history could not be kept due to lack of signatures. List of contributors were attached in the README as thanks to the original contributors. READMEs were merged: first the proposal README, then the original readme from Accenture. Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
8d0bee3
to
03561cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @hugo-borne would you like to take a review before pressing the big green button? 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 major problem:
- module import in /examples/simple-asset-transfer is pointing to another private repo. We need to change this line to point to the current repo
2 minor comments:
- some config files are pointing to our old test system
- package versions are still "1.0.0-beta"
|
||
### Contributors (unsigned commits could not be included in the lab repo) | ||
|
||
67 Hugo BORNE-PONS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are clearly duplicates, should we aggregate into a more comprehensive list?
89 hugo borne-pons
25 denis glotov
38 mykhailo lonin
15 vladimir agekin
12 naima hamouma
5 valerijs kurme
3 mihails gulajevs
2 dimitrijs rulovs
2 unknown
1 peter somogyvari
@@ -0,0 +1,58 @@ | |||
{ | |||
"version": "1.0.0-beta.rc.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We suggested changing the version to 0.1.0 with the open-source release
(package.lock will have to be updated accordingly if we make the change)
"express-bearer-token": "^2.4.0", | ||
"express-jwt": "^5.3.1", | ||
"express-session": "^1.16.2", | ||
"@hyperledger/blockchain-integration-framework": "git+https://gitlab+deploy-token-14:5_sD47zyyyZPCkfRJJsi@code-sa.techlabs.accenture.com/git/blockchain/_exploration/interoperability/after-portal.git#feature/corda-scenario", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/!\ Important
This is a module reference to our internal git repo. We need to make a reference to this repo to make it work. (That's a nasty one) You cannot detect it if you have access to both repos
@@ -0,0 +1,53 @@ | |||
{ | |||
"version": "1.0.0-beta.rc.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version 0.1.0?
@@ -0,0 +1,53 @@ | |||
{ | |||
"version": "1.0.0-beta.rc.0", | |||
"name": "@hyperledger/blockchain-integration-framework", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hyperledger/blockchain-integration-framework/quorum-api?
@@ -0,0 +1,90 @@ | |||
const crypto = require(`crypto`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change IPs to localhost to avoid confusion
|
||
it(`instance lacking params should throw`, function () { | ||
const options = { | ||
url: `http://10.112.50.34:4000`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some IPs are still pointing to the old config
@@ -0,0 +1,52 @@ | |||
{ | |||
"version": "1.0.0-beta.rc.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version 0.1.0?
Abandoning this in favor of #3 as per our internal discussions. |
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
A second attempt at fixing the release automation. The missing piece was that some of the Indy SDK dependencies were not installed by default and we forgot to run the ci.sh script to take care of that within this workflow action. With this fix now we have an additional step in the action which takes care of installing the OS level build dependencies for the project. Fixes #1951 Fixes #2069 Fixes #2175 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Signed-off-by: sandeep.nishad1 <sandeep.nishad1@ibm.com>
Fabric CLI Upgrade to handle IIN Agents and Counter Attested Foreign Memberships
Contains the code donated by Accenture as part of the lab
Commit history could not be kept due to lack of signatures.
List of contributors were attached in the README as thanks to the original contributors.
READMEs were merged: first the proposal README, then the original readme from Accenture.
The contents in this PR are taken from the dev branch of the original internal Accenture code repository.