-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(release): missing @hyperledger/cactus-cmd-socket-server npm package #2069
Comments
Is it possible that cactus-cmd-socket-server has shifted to cactus-cmd-api-server? |
@outSH Do you know for a fact that it used to be there? |
@petermetz No, I'm not 100% sure. Nevertheless, it would be nice to have it on npm like the other packages, so please upload it if possible. |
@petermetz Now that #2105 is merge and the name of package is consistent, can you publish this package to npm? I need to use it in some other Dockerfiles |
@outSH Apologies for the delay! Yes, I'll publish a new release with this package included ASAP! |
Also manually changing the "publishConfig" property of the packages/cactus-cmd-socketio-server/package.json file because it was not set to public which excluded it from the release automation altogether in previous releases, causing this bug to be reported: #2069 Fixes #2069 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Also manually changing the "publishConfig" property of the packages/cactus-cmd-socketio-server/package.json file because it was not set to public which excluded it from the release automation altogether in previous releases, causing this bug to be reported: #2069 Fixes #2069 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Re-opening until we can fix the release automation problems. |
A second attempt at fixing the release automation. The missing piece was that some of the Indy SDK dependencies were not installed by default and we forgot to run the ci.sh script to take care of that within this workflow action. With this fix now we have an additional step in the action which takes care of installing the OS level build dependencies for the project. Fixes hyperledger-cacti#1951 Fixes hyperledger-cacti#2069 Fixes hyperledger-cacti#2175 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@outSH I think I already said it but just to be sure pinging here as well: v1.1.2 artifacts are up on npmjs.com now. |
There's no
@hyperledger/cactus-cmd-socket-server:1.0.0
package in official NPM repository. It's required by socketio-based connector plugins (validators). Without this dependency, building of validator docker images fail. These images are required by electricty-trade and asset-trade sample apps, so without them, it's impossible to run them through the docker environment.I'm pretty sure this package was available in NPM earlier on, please restore it if possible.
@izuru0 @jagpreetsinghsasan @petermetz
The text was updated successfully, but these errors were encountered: