-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(headers): add AcceptCharset header #300
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
use header::{self, Charset, QualityItem}; | ||
|
||
/// The `Accept-Charset` header | ||
/// | ||
/// The `Accept-Charset` header can be used by clients to indicate what | ||
/// response charsets they accept. | ||
#[derive(Clone, PartialEq, Debug)] | ||
pub struct AcceptCharset(pub Vec<QualityItem<Charset>>); | ||
|
||
impl_list_header!(AcceptCharset, | ||
"Accept-Charset", | ||
Vec<QualityItem<Charset>>); | ||
|
||
|
||
#[test] | ||
fn test_parse_header() { | ||
let a: AcceptCharset = header::Header::parse_header( | ||
[b"iso-8859-5, iso-8859-6;q=0.8".to_vec()].as_slice()).unwrap(); | ||
let b = AcceptCharset(vec![ | ||
QualityItem{item: Charset::Iso_8859_5, quality: 1.0}, | ||
QualityItem{item: Charset::Iso_8859_6, quality: 0.8}, | ||
]); | ||
assert_eq!(format!("{}", a), format!("{}", b)); | ||
assert_eq!(a, b); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,150 @@ | ||
use std::fmt::{self,Display}; | ||
use std::str::FromStr; | ||
use std::ascii::AsciiExt; | ||
|
||
use self::Charset::*; | ||
|
||
/// A Mime charset. | ||
/// | ||
/// The string representation is normalised to upper case. | ||
/// | ||
/// See http://www.iana.org/assignments/character-sets/character-sets.xhtml | ||
#[derive(Clone,Debug,PartialEq)] | ||
#[allow(non_camel_case_types)] | ||
pub enum Charset{ | ||
/// US ASCII | ||
Us_Ascii, | ||
/// ISO-8859-1 | ||
Iso_8859_1, | ||
/// ISO-8859-2 | ||
Iso_8859_2, | ||
/// ISO-8859-3 | ||
Iso_8859_3, | ||
/// ISO-8859-4 | ||
Iso_8859_4, | ||
/// ISO-8859-5 | ||
Iso_8859_5, | ||
/// ISO-8859-6 | ||
Iso_8859_6, | ||
/// ISO-8859-7 | ||
Iso_8859_7, | ||
/// ISO-8859-8 | ||
Iso_8859_8, | ||
/// ISO-8859-9 | ||
Iso_8859_9, | ||
/// ISO-8859-10 | ||
Iso_8859_10, | ||
/// Shift_JIS | ||
Shift_Jis, | ||
/// EUC-JP | ||
Euc_Jp, | ||
/// ISO-2022-KR | ||
Iso_2022_Kr, | ||
/// EUC-KR | ||
Euc_Kr, | ||
/// ISO-2022-JP | ||
Iso_2022_Jp, | ||
/// ISO-2022-JP-2 | ||
Iso_2022_Jp_2, | ||
/// ISO-8859-6-E | ||
Iso_8859_6_E, | ||
/// ISO-8859-6-I | ||
Iso_8859_6_I, | ||
/// ISO-8859-8-E | ||
Iso_8859_8_E, | ||
/// ISO-8859-8-I | ||
Iso_8859_8_I, | ||
/// GB2312 | ||
Gb2312, | ||
/// Big5 | ||
Big5, | ||
/// KOI8-R | ||
Koi8_R, | ||
/// An arbitrary charset specified as a string | ||
Ext(String) | ||
} | ||
|
||
impl Charset { | ||
fn name(&self) -> &str { | ||
match *self { | ||
Us_Ascii => "US-ASCII", | ||
Iso_8859_1 => "ISO-8859-1", | ||
Iso_8859_2 => "ISO-8859-2", | ||
Iso_8859_3 => "ISO-8859-3", | ||
Iso_8859_4 => "ISO-8859-4", | ||
Iso_8859_5 => "ISO-8859-5", | ||
Iso_8859_6 => "ISO-8859-6", | ||
Iso_8859_7 => "ISO-8859-7", | ||
Iso_8859_8 => "ISO-8859-8", | ||
Iso_8859_9 => "ISO-8859-9", | ||
Iso_8859_10 => "ISO-8859-10", | ||
Shift_Jis => "Shift-JIS", | ||
Euc_Jp => "EUC-JP", | ||
Iso_2022_Kr => "ISO-2022-KR", | ||
Euc_Kr => "EUC-KR", | ||
Iso_2022_Jp => "ISO-2022-JP", | ||
Iso_2022_Jp_2 => "ISO-2022-JP-2", | ||
Iso_8859_6_E => "ISO-8859-6-E", | ||
Iso_8859_6_I => "ISO-8859-6-I", | ||
Iso_8859_8_E => "ISO-8859-8-E", | ||
Iso_8859_8_I => "ISO-8859-8-I", | ||
Gb2312 => "GB2312", | ||
Big5 => "5", | ||
Koi8_R => "KOI8-R", | ||
Ext(ref s) => &s[] | ||
} | ||
} | ||
} | ||
|
||
impl Display for Charset { | ||
fn fmt(&self, fmt: &mut fmt::Formatter) -> fmt::Result { | ||
write!(fmt, "{}", self.name()) | ||
} | ||
} | ||
|
||
impl FromStr for Charset { | ||
type Err = (); | ||
fn from_str(s: &str) -> Result<Charset, ()> { | ||
Ok(match s.to_ascii_uppercase().as_slice() { | ||
"US-ASCII" => Us_Ascii, | ||
"ISO-8859-1" => Iso_8859_1, | ||
"ISO-8859-2" => Iso_8859_2, | ||
"ISO-8859-3" => Iso_8859_3, | ||
"ISO-8859-4" => Iso_8859_4, | ||
"ISO-8859-5" => Iso_8859_5, | ||
"ISO-8859-6" => Iso_8859_6, | ||
"ISO-8859-7" => Iso_8859_7, | ||
"ISO-8859-8" => Iso_8859_8, | ||
"ISO-8859-9" => Iso_8859_9, | ||
"ISO-8859-10" => Iso_8859_10, | ||
"Shift-JIS" => Shift_Jis, | ||
"EUC-JP" => Euc_Jp, | ||
"ISO-2022-KR" => Iso_2022_Kr, | ||
"EUC-KR" => Euc_Kr, | ||
"ISO-2022-JP" => Iso_2022_Jp, | ||
"ISO-2022-JP-2" => Iso_2022_Jp_2, | ||
"ISO-8859-6-E" => Iso_8859_6_E, | ||
"ISO-8859-6-I" => Iso_8859_6_I, | ||
"ISO-8859-8-E" => Iso_8859_8_E, | ||
"ISO-8859-8-I" => Iso_8859_8_I, | ||
"GB2312" => Gb2312, | ||
"5" => Big5, | ||
"KOI8-R" => Koi8_R, | ||
s => Ext(s.to_string()) | ||
}) | ||
} | ||
} | ||
|
||
#[test] | ||
fn test_parse() { | ||
assert_eq!(Us_Ascii,"us-ascii".parse().unwrap()); | ||
assert_eq!(Us_Ascii,"US-Ascii".parse().unwrap()); | ||
assert_eq!(Us_Ascii,"US-ASCII".parse().unwrap()); | ||
assert_eq!(Ext("ABCD".to_string()),"abcd".parse().unwrap()); | ||
} | ||
|
||
#[test] | ||
fn test_display() { | ||
assert_eq!("US-ASCII", format!("{}", Us_Ascii)); | ||
assert_eq!("ABCD", format!("{}", Ext("ABCD".to_string()))); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,9 @@ | ||
pub use self::charset::Charset; | ||
pub use self::encoding::Encoding; | ||
pub use self::entity::EntityTag; | ||
pub use self::quality_item::{QualityItem, qitem}; | ||
|
||
mod charset; | ||
mod encoding; | ||
mod entity; | ||
mod quality_item; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't that be
"SHIFT-JIS"
since you're using uppercase?