feat(headers): add AcceptCharset header

[hugoduncan]

Adds support for the Accept-Charset header. Encodes the charset as a string.

[pyfisch]

Looks good to me, although I would prefer a stronger typed charset type.

[hugoduncan]

I am happy to add an enum for the charset type, but I think we would need to agree which list of charsets to include (and have the capability of specifying a string). Would the list in the "Preferred MIME Name" column of the IANA rgistry (as suggested by rfc2616) be suitable?

[seanmonstar]

I'd prefer stronger typed also, but that list is quite long. Can either keep as String for now, or try an enum with 5-10 of the most common, and then a Ext(String) variant.

[pyfisch]

Actually the list is not that long. It can be a separate crate like mime.rs

[hugoduncan]

The suggested list has 24 entries, which seems reasonable to me. @pyfisch Would you be interested in owning such a crate (seems it would go well alongside rust-language-tags)? @seanmonstar would you be OK adding such a dependency?

[reem]

24 entries is short enough to live in hyper imo, but I wouldn't mind another crate in hyperium to help split things up.

[seanmonstar]

24 can fit in hyper. I made mime a separate crate as it seemed useful for others.

[hugoduncan]

Just noticed https://github.com/lifthrasiir/rust-encoding.

[seanmonstar]

Oh nice. That'd be rad if we could integrate that, since we already depend on encoding (via rust-url). @lifthrasiir thoughts about a type that we could use in the headers? A label?

[lifthrasiir]

@seanmonstar lifthrasiir/rust-encoding#64 is probably relevant. I'm not sure whether this is truly desirable or not though.

[seanmonstar]

@lifthrasiir yep, that sounds exactly what would be best here...

[sbstp]

Shouldn't that be "SHIFT-JIS" since you're using uppercase?

[seanmonstar]

merged manually

[sbstp]

I'm pretty sure the Shift-JIS bug is still there.
I added a test, assert_eq!(Shift_Jis,"Shift-JIS".parse().unwrap()); and it doesn't work.
The line "Shift-JIS" => Shift_Jis, never matches and it goes straight to Ext("SHIFT-JIS").

[seanmonstar]

@sbstp oh! i see what you mean, since to_ascii_uppercase() is called just before it. I was quite confused at first, since it's Shift-JIS in both from_str and name.

[sbstp]

Do you want me to PR a fix?

[seanmonstar]

Sure. Though, if the name is supposed to mixed case like that, then the fix
must be about using to_uppercase. If it's not supposed to, then your
suggestion works perfectly.

On Tue, Mar 3, 2015, 9:15 PM Simon Bernier St-Pierre <
notifications@github.com> wrote:

Do you want me to PR a fix?

—
Reply to this email directly or view it on GitHub
#300 (comment).

[sbstp]

I was only going to fix the parsing part, since uppercase should handle mixed case.