fix: dangling event listeners on menu #1071
Conversation
🦋 Changeset detectedLatest commit: 8dc8bbd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
| callbacksToDispose.push(disposeKeydown); | ||
|
|
||
| return () => { | ||
| executeCallbacks(callbacksToDispose); |
packages/bits-ui/src/lib/bits/utilities/is-using-keyboard/is-using-keyboard.svelte.ts
Outdated
Show resolved
Hide resolved
|
Very nice work. Tbh, I hadn't even though of the idea of a global |
|
Not sure about this, but should I add a "minor" changeset because the new |
|
We just do everything "patch" while we're in pre-release mode so it's one flat changelog when we merge/release 1.0. Future majors will have appropriate patch/minor/major(breaking) changes annotated. I don't mind exporting I can do that once I'm done with work later unless you want to! Thanks again for this! |
|
Feel free to take it from here :) |
Fixes #1070
I took the opportunity to optimize the determination of the user's input mode (pointer or keyboard). Now, only three event listeners are registered and can be shared between multiple components.
I took inspiration from @huntabyte's branch
fix/focus-scopingwhere a classIsUsingKeyboardis already implemented.Many thanks to @chbert with whom I troubleshot this issue extensively :)