next: No cleanup of event listeners in menu component

[Fruup]

Describe the bug

This applies to bits-ui@1.0.0-next.78.

When using the dropdown component (or any menu component), event listeners are registered to determine if the user is using a keyboard for navigation. The cleanup logic is faulty, leading to dangling event listeners (and a lot of them). On large sites, this soon leads to performance issues.

---

This:

bits-ui/packages/bits-ui/src/lib/bits/menu/menu.svelte.ts

Line 110 in 5792ab6

executeCallbacks(callbacksToDispose);

should be

executeCallbacks(...callbacksToDispose)();

(Frankly, the definition of executeCallbacks is not very clear or type-safe.)

---

Will open a PR with a fix :)

Reproduction

https://stackblitz.com/edit/bits-ui-missing-listener-cleanup-repro?file=src%2Froutes%2F%2Blayout.svelte

Logs

System Info

System:
    OS: macOS 15.1.1
    CPU: (10) arm64 Apple M1 Pro
    Memory: 100.13 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.12.2 - ~/.nvm/versions/node/v20.12.2/bin/node
    npm: 10.5.0 - ~/.nvm/versions/node/v20.12.2/bin/npm
    pnpm: 9.15.3 - ~/Library/pnpm/pnpm
    bun: 1.2.1 - ~/.bun/bin/bun
  Browsers:
    Chrome: 132.0.6834.111
    Safari: 18.1.1
  npmPackages:
    @sveltejs/kit: ^2.0.0 => 2.16.1 
    bits-ui: 1.0.0-next.78 => 1.0.0-next.78 
    svelte: ^5.0.0 => 5.19.4

Severity

annoyance