Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix _load_state_dict_into_meta_model with device_map=None #36488

Merged
merged 2 commits into from
Mar 2, 2025
Merged

Fix _load_state_dict_into_meta_model with device_map=None #36488

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0615bbe
Fix _load_state_dict_into_meta_model with device_map=None
hlky Mar 1, 2025
512dc62
Update src/transformers/modeling_utils.py
hlky Mar 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/transformers/modeling_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -785,8 +785,7 @@ def _load_state_dict_into_meta_model(
tensor_device = None
if device_map is not None and device_map.get("", None) is not None:
tensor_device = device_map[""].index if isinstance(device_map[""], torch.device) else device_map[""]

device_map_regex = "|".join(sorted(device_map.keys(), reverse=True))
device_map_regex = "|".join(sorted(device_map.keys(), reverse=True))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah sorry, i missed that. Make sure to put it under the condition if device_map is not None. Right now it requires that it also have "" in its keys.


# we need this later to initialize tensor parallelism
if device_mesh is not None:
Expand Down