Fix _load_state_dict_into_meta_model with device_map=None #36488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. When it is ready for review, please click the |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
SunMarc
approved these changes
Mar 1, 2025
src/transformers/modeling_utils.py
Outdated
Comment on lines
789
to
788
| device_map_regex = "|".join(sorted(device_map.keys(), reverse=True)) | ||
| device_map_regex = "|".join(sorted(device_map.keys(), reverse=True)) |
There was a problem hiding this comment.
Yeah sorry, i missed that. Make sure to put it under the condition if device_map is not None. Right now it requires that it also have "" in its keys.
hlky
commented
Mar 1, 2025
garrett361
pushed a commit
to garrett361/transformers
that referenced
this pull request
Mar 4, 2025
…e#36488) * Fix _load_state_dict_into_meta_model with device_map=None * Update src/transformers/modeling_utils.py
garrett361
pushed a commit
to garrett361/transformers
that referenced
this pull request
Mar 4, 2025
…e#36488) * Fix _load_state_dict_into_meta_model with device_map=None * Update src/transformers/modeling_utils.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
https://github.com/huggingface/diffusers/actions/runs/13604967458/job/38035399161?pr=10898
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.