Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the config class comparison for remote code models #35592

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Fix the config class comparison for remote code models #35592

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c56594b
Fix the config class comparison when repeatedly saving and loading re…
Rocketknight1 Jan 9, 2025
0bb5b32
once again you have committed your debug breakpoint
Rocketknight1 Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/transformers/models/auto/auto_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,7 +580,7 @@ def register(cls, config_class, model_class, exist_ok=False):
model_class ([`PreTrainedModel`]):
The model to register.
"""
if hasattr(model_class, "config_class") and str(model_class.config_class) != str(config_class):
if hasattr(model_class, "config_class") and model_class.config_class.__name__ != config_class.__name__:
raise ValueError(
"The model class you are passing has a `config_class` attribute that is not consistent with the "
f"config class you passed (model has {model_class.config_class} and you passed {config_class}. Fix "
Expand Down
Loading