Fix the config class comparison for remote code models #35592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4c0d2ac to
0bb5b32
Compare
|
cc @ArthurZucker for review! |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
gentle ping @ArthurZucker, and sorry for the spam! |
ArthurZucker
approved these changes
Jan 27, 2025
bursteratom
pushed a commit
to bursteratom/transformers
that referenced
this pull request
Jan 31, 2025
…5592) * Fix the config class comparison when repeatedly saving and loading remote code models * once again you have committed your debug breakpoint
elvircrn
pushed a commit
to elvircrn/transformers
that referenced
this pull request
Feb 13, 2025
…5592) * Fix the config class comparison when repeatedly saving and loading remote code models * once again you have committed your debug breakpoint
sbucaille
pushed a commit
to sbucaille/transformers
that referenced
this pull request
Feb 16, 2025
…5592) * Fix the config class comparison when repeatedly saving and loading remote code models * once again you have committed your debug breakpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The config class comparison previously used
str(model_class.config_class), which resulted in mismatches because the actual class was loaded from a cache dir and therefore had the cache dir path as part of its full class name string.This new test just uses
model_class.__name__which is much less error-prone.Fixes #35584, related to #29854