Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commont bot CI for other jobs (generation / quantization) #35341

Merged
merged 5 commits into from
Feb 4, 2025

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Dec 19, 2024

What does this PR do?

See example (dummy) run here

@ydshieh ydshieh requested a review from ArthurZucker December 19, 2024 12:57
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@ydshieh ydshieh changed the title Commont bot CI for other jobs (generation / quantization) [DON'T MERGE] Commont bot CI for other jobs (generation / quantization) Dec 20, 2024
@ydshieh ydshieh marked this pull request as draft December 20, 2024 14:37
@ydshieh ydshieh force-pushed the commont_bot_pour_Q branch from 8794e50 to a9dcc50 Compare January 21, 2025 10:36
@ydshieh ydshieh changed the title [DON'T MERGE] Commont bot CI for other jobs (generation / quantization) Commont bot CI for other jobs (generation / quantization) Jan 21, 2025
@ydshieh ydshieh marked this pull request as ready for review January 21, 2025 11:10
@ydshieh ydshieh requested a review from SunMarc January 21, 2025 11:11
@ydshieh ydshieh force-pushed the commont_bot_pour_Q branch from a9dcc50 to eff9ad1 Compare January 22, 2025 09:13
@ydshieh
Copy link
Collaborator Author

ydshieh commented Jan 22, 2025

run-slow: vit

Copy link

This comment contains run-slow, running the specified jobs: ['models/vit'] ...

@ydshieh
Copy link
Collaborator Author

ydshieh commented Jan 22, 2025

run-slow: vit

Copy link

This comment contains run-slow, running the specified jobs: ['models/vit'] ...

@ydshieh
Copy link
Collaborator Author

ydshieh commented Jan 31, 2025

@SunMarc if you have some bandwidth and feel happy to take a look this PR, we can merge once you are happy and thus enabling PR CI for quantization.

Otherwise we can wait the core maintainer's review.

@SunMarc
Copy link
Member

SunMarc commented Feb 4, 2025

run slow bnb

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks for this work ! Could you give me the rights to run slow tests also ?

@ydshieh
Copy link
Collaborator Author

ydshieh commented Feb 4, 2025

damm, shame on me. I will add you and @muellerzr

(the change in this PR won't be effective before it's merged to main, so you don't need to try here)

@ydshieh ydshieh merged commit f19bfa5 into main Feb 4, 2025
11 checks passed
@ydshieh ydshieh deleted the commont_bot_pour_Q branch February 4, 2025 13:42
@ydshieh
Copy link
Collaborator Author

ydshieh commented Feb 4, 2025

run slow: bnb

@ydshieh
Copy link
Collaborator Author

ydshieh commented Feb 4, 2025

@SunMarc
Copy link
Member

SunMarc commented Feb 4, 2025

in the PR you linked, the tests couldn't run because of a SHA issue. Is it expected ?

@ydshieh
Copy link
Collaborator Author

ydshieh commented Feb 4, 2025

ahh, no not expected. Thanks , I am checking ...

@ydshieh
Copy link
Collaborator Author

ydshieh commented Feb 4, 2025

#35972 (comment)

https://github.com/huggingface/transformers/actions/runs/13139182252/job/36661951810

elvircrn pushed a commit to elvircrn/transformers that referenced this pull request Feb 13, 2025
…gface#35341)

* quantization CI on PRs

* fix

* fix

* add 2 members

---------

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
sbucaille pushed a commit to sbucaille/transformers that referenced this pull request Feb 16, 2025
…gface#35341)

* quantization CI on PRs

* fix

* fix

* add 2 members

---------

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants