fix

huggingface · Jan 22, 2025 · eff9ad1 · eff9ad1
1 parent b6df1de
commit eff9ad1
Showing 1 changed file with 97 additions and 89 deletions.
diff --git a/.github/workflows/self-comment-ci.yml b/.github/workflows/self-comment-ci.yml
@@ -193,95 +193,96 @@ jobs:
       image: huggingface/transformers-all-latest-gpu
       options: --gpus all --shm-size "16gb" --ipc host -v /mnt/cache/.cache/huggingface:/mnt/cache/
     steps:
-    - name: Echo input and matrix info
-      shell: bash
-      run: |
-        echo "${{ matrix.folders }}"
-
-    - name: Echo folder ${{ matrix.folders }}
-      shell: bash
-      # For folders like `models/bert`, set an env. var. (`matrix_folders`) to `models_bert`, which will be used to
-      # set the artifact folder names (because the character `/` is not allowed).
-      run: |
-        echo "${{ matrix.folders }}"
-        matrix_folders=${{ matrix.folders }}
-        matrix_folders=${matrix_folders/'models/'/'models_'}
-        echo "$matrix_folders"
-        echo "matrix_folders=$matrix_folders" >> $GITHUB_ENV
-
-    - name: Checkout to PR merge commit
-      working-directory: /transformers
-      run: |
-        git fetch origin refs/pull/${{ needs.get-pr-number.outputs.PR_NUMBER }}/merge:refs/remotes/pull/${{ needs.get-pr-number.outputs.PR_NUMBER }}/merge
-        git checkout refs/remotes/pull/${{ needs.get-pr-number.outputs.PR_NUMBER }}/merge
-        git log -1 --format=%H
-
-    - name: Verify merge commit SHA
-      env:
-        VERIFIED_PR_MERGE_SHA: ${{ needs.get-sha.outputs.PR_MERGE_SHA }}
-      run: |
-        PR_MERGE_SHA=$(git log -1 --format=%H)
-        if [ $PR_MERGE_SHA != $VERIFIED_PR_MERGE_SHA ]; then
-          echo "The merged commit SHA is not the same as the verified one! Security issue detected, abort the workflow!";
-          exit -1;
-
-    - name: Reinstall transformers in edit mode (remove the one installed during docker image build)
-      working-directory: /transformers
-      run: python3 -m pip uninstall -y transformers && python3 -m pip install -e .
-
-    - name: NVIDIA-SMI
-      run: |
-        nvidia-smi
-
-    - name: Set `machine_type` for report and artifact names
-      working-directory: /transformers
-      shell: bash
-      run: |
-        echo "${{ matrix.machine_type }}"
-        if [ "${{ matrix.machine_type }}" = "aws-g4dn-2xlarge-cache" ]; then
-          machine_type=single-gpu
-        elif [ "${{ matrix.machine_type }}" = "aws-g4dn-12xlarge-cache" ]; then
-          machine_type=multi-gpu
-        else
-          machine_type=${{ matrix.machine_type }}
-        fi
-        echo "$machine_type"
-        echo "machine_type=$machine_type" >> $GITHUB_ENV
-
-    - name: Environment
-      working-directory: /transformers
-      run: |
-        python3 utils/print_env.py
-
-    - name: Show installed libraries and their versions
-      working-directory: /transformers
-      run: pip freeze
-
-    - name: Run all tests on GPU
-      working-directory: /transformers
-      run: |
-        export CUDA_VISIBLE_DEVICES="$(python3 utils/set_cuda_devices_for_ci.py --test_folder ${{ matrix.folders }})"
-        echo $CUDA_VISIBLE_DEVICES
-        python3 -m pytest -v -rsfE --make-reports=${{ env.machine_type }}_run_models_gpu_${{ matrix.folders }}_test_reports tests/${{ matrix.folders }}
-
-    - name: Failure short reports
-      if: ${{ failure() }}
-      continue-on-error: true
-      run: cat /transformers/reports/${{ env.machine_type }}_run_models_gpu_${{ matrix.folders }}_test_reports/failures_short.txt
-
-    - name: Make sure report directory exists
-      shell: bash
-      run: |
-        mkdir -p /transformers/reports/${{ env.machine_type }}_run_models_gpu_${{ matrix.folders }}_test_reports
-        echo "hello" > /transformers/reports/${{ env.machine_type }}_run_models_gpu_${{ matrix.folders }}_test_reports/hello.txt
-        echo "${{ env.machine_type }}_run_models_gpu_${{ matrix.folders }}_test_reports"
-
-    - name: "Test suite reports artifacts: ${{ env.machine_type }}_run_models_gpu_${{ env.matrix_folders }}_test_reports"
-      if: ${{ always() }}
-      uses: actions/upload-artifact@v4
-      with:
-        name: ${{ env.machine_type }}_run_models_gpu_${{ env.matrix_folders }}_test_reports
-        path: /transformers/reports/${{ env.machine_type }}_run_models_gpu_${{ matrix.folders }}_test_reports
+      - name: Echo input and matrix info
+        shell: bash
+        run: |
+          echo "${{ matrix.folders }}"
+
+      - name: Echo folder ${{ matrix.folders }}
+        shell: bash
+        # For folders like `models/bert`, set an env. var. (`matrix_folders`) to `models_bert`, which will be used to
+        # set the artifact folder names (because the character `/` is not allowed).
+        run: |
+          echo "${{ matrix.folders }}"
+          matrix_folders=${{ matrix.folders }}
+          matrix_folders=${matrix_folders/'models/'/'models_'}
+          echo "$matrix_folders"
+          echo "matrix_folders=$matrix_folders" >> $GITHUB_ENV
+
+      - name: Checkout to PR merge commit
+        working-directory: /transformers
+        run: |
+          git fetch origin refs/pull/${{ needs.get-pr-number.outputs.PR_NUMBER }}/merge:refs/remotes/pull/${{ needs.get-pr-number.outputs.PR_NUMBER }}/merge
+          git checkout refs/remotes/pull/${{ needs.get-pr-number.outputs.PR_NUMBER }}/merge
+          git log -1 --format=%H
+
+      - name: Verify merge commit SHA
+        env:
+          VERIFIED_PR_MERGE_SHA: ${{ needs.get-sha.outputs.PR_MERGE_SHA }}
+        working-directory: /transformers
+        run: |
+          PR_MERGE_SHA=$(git log -1 --format=%H)
+          if [ $PR_MERGE_SHA != $VERIFIED_PR_MERGE_SHA ]; then
+            echo "The merged commit SHA is not the same as the verified one! Security issue detected, abort the workflow!";
+            exit -1;
+
+      - name: Reinstall transformers in edit mode (remove the one installed during docker image build)
+        working-directory: /transformers
+        run: python3 -m pip uninstall -y transformers && python3 -m pip install -e .
+
+      - name: NVIDIA-SMI
+        run: |
+          nvidia-smi
+
+      - name: Set `machine_type` for report and artifact names
+        working-directory: /transformers
+        shell: bash
+        run: |
+          echo "${{ matrix.machine_type }}"
+          if [ "${{ matrix.machine_type }}" = "aws-g4dn-2xlarge-cache" ]; then
+            machine_type=single-gpu
+          elif [ "${{ matrix.machine_type }}" = "aws-g4dn-12xlarge-cache" ]; then
+            machine_type=multi-gpu
+          else
+            machine_type=${{ matrix.machine_type }}
+          fi
+          echo "$machine_type"
+          echo "machine_type=$machine_type" >> $GITHUB_ENV
+
+      - name: Environment
+        working-directory: /transformers
+        run: |
+          python3 utils/print_env.py
+
+      - name: Show installed libraries and their versions
+        working-directory: /transformers
+        run: pip freeze
+
+      - name: Run all tests on GPU
+        working-directory: /transformers
+        run: |
+          export CUDA_VISIBLE_DEVICES="$(python3 utils/set_cuda_devices_for_ci.py --test_folder ${{ matrix.folders }})"
+          echo $CUDA_VISIBLE_DEVICES
+          python3 -m pytest -v -rsfE --make-reports=${{ env.machine_type }}_run_models_gpu_${{ matrix.folders }}_test_reports tests/${{ matrix.folders }}
+
+      - name: Failure short reports
+        if: ${{ failure() }}
+        continue-on-error: true
+        run: cat /transformers/reports/${{ env.machine_type }}_run_models_gpu_${{ matrix.folders }}_test_reports/failures_short.txt
+
+      - name: Make sure report directory exists
+        shell: bash
+        run: |
+          mkdir -p /transformers/reports/${{ env.machine_type }}_run_models_gpu_${{ matrix.folders }}_test_reports
+          echo "hello" > /transformers/reports/${{ env.machine_type }}_run_models_gpu_${{ matrix.folders }}_test_reports/hello.txt
+          echo "${{ env.machine_type }}_run_models_gpu_${{ matrix.folders }}_test_reports"
+
+      - name: "Test suite reports artifacts: ${{ env.machine_type }}_run_models_gpu_${{ env.matrix_folders }}_test_reports"
+        if: ${{ always() }}
+        uses: actions/upload-artifact@v4
+        with:
+          name: ${{ env.machine_type }}_run_models_gpu_${{ env.matrix_folders }}_test_reports
+          path: /transformers/reports/${{ env.machine_type }}_run_models_gpu_${{ matrix.folders }}_test_reports
 
   run_quantization_torch_gpu:
     name: Run all tests for a quantization
@@ -306,6 +307,7 @@ jobs:
           matrix_folders=${matrix_folders/'quantization/'/'quantization_'}
           echo "$matrix_folders"
           echo "matrix_folders=$matrix_folders" >> $GITHUB_ENV
+
       - name: Checkout to PR merge commit
         working-directory: /transformers
         run: |
@@ -316,6 +318,7 @@ jobs:
       - name: Verify merge commit SHA
         env:
           VERIFIED_PR_MERGE_SHA: ${{ needs.get-sha.outputs.PR_MERGE_SHA }}
+        working-directory: /transformers
         run: |
           PR_MERGE_SHA=$(git log -1 --format=%H)
           if [ $PR_MERGE_SHA != $VERIFIED_PR_MERGE_SHA ]; then
@@ -328,6 +331,7 @@ jobs:
       - name: NVIDIA-SMI
         run: |
           nvidia-smi
+
       - name: Set `machine_type` for report and artifact names
         working-directory: /transformers
         shell: bash
@@ -342,10 +346,12 @@ jobs:
           fi
           echo "$machine_type"
           echo "machine_type=$machine_type" >> $GITHUB_ENV
+
       - name: Environment
         working-directory: /transformers
         run: |
           python3 utils/print_env.py
+
       - name: Show installed libraries and their versions
         working-directory: /transformers
         run: pip freeze
@@ -354,6 +360,7 @@ jobs:
         working-directory: /transformers
         run: |
           python3 -m pytest -v --make-reports=${{ env.machine_type }}_run_quantization_torch_gpu_${{ matrix.folders }}_test_reports tests/${{ matrix.folders }}
+
       - name: Failure short reports
         if: ${{ failure() }}
         continue-on-error: true
@@ -365,6 +372,7 @@ jobs:
           mkdir -p /transformers/reports/${{ env.machine_type }}_run_quantization_gpu_${{ matrix.folders }}_test_reports
           echo "hello" > /transformers/reports/${{ env.machine_type }}_run_quantization_gpu_${{ matrix.folders }}_test_reports/hello.txt
           echo "${{ env.machine_type }}_run_quantization_gpu_${{ matrix.folders }}_test_reports"
+
       - name: "Test suite reports artifacts: ${{ env.machine_type }}_run_quantization_torch_gpu_${{ env.matrix_folders }}_test_reports"
         if: ${{ always() }}
         uses: actions/upload-artifact@v4