Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed ruff configuration to avoid deprecated configuration warning #30179

Merged
merged 3 commits into from
Apr 11, 2024

Conversation

Sai-Suraj-27
Copy link
Contributor

What does this PR do?

Currently, if we run ruff, we are getting the following warning

image

This is because, the configuration that is currently used for ruff in pyproject.toml is deprecated. So, I have updated the configuration according to the updated configuration rules of ruff. The warning is no longer coming and all the ruff checks are also successfully passing.

Before submitting

Who can review?

From my observations through git blame of pyproject.toml
@ArthurZucker

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@amyeroberts amyeroberts merged commit e516d1b into huggingface:main Apr 11, 2024
7 checks passed
@Sai-Suraj-27 Sai-Suraj-27 deleted the fix_ruff_config branch July 10, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants