Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated ruff configuration to avoid deprecated configuration warning #7637

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

Sai-Suraj-27
Copy link
Contributor

@Sai-Suraj-27 Sai-Suraj-27 commented Apr 11, 2024

What does this PR do?

Currently, if we run ruff, we are getting the following warning

image

This is because, the configuration that is currently used for ruff in pyproject.toml is deprecated. So, I have updated the configuration according to the updated configuration rules of ruff. The warning is no longer coming and all the ruff checks are also successfully passing.

Before submitting

Who can review?

Core library:

@sayakpaul sayakpaul requested review from kashif and yiyixuxu April 11, 2024 06:21
Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@Sai-Suraj-27
Copy link
Contributor Author

Sai-Suraj-27 commented Apr 11, 2024

Works for me.

Thanks for the review @sayakpaul. I see the same problem in pyproject.toml file of the transformers repo too. Should I go ahead and make a similar PR there?

Edit: I made the PR and it got merged 👍🏻.

@yiyixuxu yiyixuxu merged commit c726d02 into huggingface:main Apr 17, 2024
sayakpaul added a commit that referenced this pull request Dec 23, 2024
…arning (#7637)

Updated ruff configuration to avoid depreceated config.

Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants