[GemmaConverter] use user_defined_symbols
#29473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
pcuenca
approved these changes
Mar 6, 2024
|
I will add a test and we can merge |
LysandreJik
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Understood! cc @ydshieh that this will introduce some failing tests in the slow CI, we're aware (maybe we can skip those until we get to it? after the release)
| @@ -52,7 +52,7 @@ | |||
| @require_sentencepiece | |||
| @require_tokenizers | |||
| class LlamaTokenizationTest(TokenizerTesterMixin, unittest.TestCase): | |||
| from_pretrained_id = "hf-internal-testing/llama-tokenizer" | |||
| from_pretrained_id = ["hf-internal-testing/llama-tokenizer", "meta-llama/Llama-2-7b-hf"] | |||
GemmaConverte] use user_defined_symbolsGemmaConverter] use user_defined_symbols
|
Thank you for warning me. But could you share with me the reason to merge before we resolve the failing tests? |
|
We need to release ! |
|
It would be very appreciated that the expected failing tests to be skipped temporarily (before they would be fixed/updated after the release). |
|
We can open a PR to skip / fix them tomorrow! |
|
Failing tests are unrelated, merging! |
This was referenced Apr 4, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #29440 by always adding the
user_defined_symbolsto the tokenizer, otherwise because no merges exist for them, they will be split.