Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_encode_decode_fast_slow_all_tokens is failing #30045

Open
ydshieh opened this issue Apr 4, 2024 · 2 comments
Open

test_encode_decode_fast_slow_all_tokens is failing #30045

ydshieh opened this issue Apr 4, 2024 · 2 comments
Assignees
@ArthurZucker
Labels
Core: Tokenization Internals of the library; Tokenization. WIP Label your PR/Issue with WIP for some long outstanding Issues/PRs that are work in progress

Comments

@ydshieh
Copy link
Collaborator

ydshieh commented Apr 4, 2024 •
edited
Loading

This test starts to fail after #29473

See #29473 (review)

#30044 skips it for now, but let's fix it once we have the bandwidth.
@ydshieh ydshieh changed the title bbbb test_encode_decode_fast_slow_all_tokens is failing Apr 4, 2024
@huggingface huggingface deleted a comment from github-actions bot May 7, 2024
@ArthurZucker
Copy link
Collaborator

@itazap ! And @molbap this is the test that would have saved you

@ArthurZucker ArthurZucker added the Core: Tokenization Internals of the library; Tokenization. label May 23, 2024
@huggingface huggingface deleted a comment from github-actions bot Jun 19, 2024
@itazap itazap mentioned this issue Jun 21, 2024
Draft
2 tasks
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@itazap itazap reopened this Jul 23, 2024
@github-actions github-actions bot closed this as completed Aug 1, 2024
@ArthurZucker ArthurZucker reopened this Aug 5, 2024
@itazap itazap reopened this Aug 19, 2024
@ArthurZucker ArthurZucker reopened this Aug 27, 2024
@ArthurZucker ArthurZucker added the WIP Label your PR/Issue with WIP for some long outstanding Issues/PRs that are work in progress label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArthurZucker ArthurZucker

Labels
Core: Tokenization Internals of the library; Tokenization. WIP Label your PR/Issue with WIP for some long outstanding Issues/PRs that are work in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ydshieh @itazap @ArthurZucker