Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update parameter name in OpenAIServerModel example #215

Closed
wants to merge 2 commits into from
Closed

docs: update parameter name in OpenAIServerModel example #215

wants to merge 2 commits into from

Conversation

xianminx
Copy link

Description:
updates the parameter name in the OpenAIServerModel example to reflect the correct usage. The changes include:

  • Renaming the parameter base_url to api_base in the documentation example.

@xianminx
Copy link
Author

It appears that @duydl modified the OpenAIServerModel class to include the use of base_url in PR #182. If that PR gets merged, this PR will have conflicts and can be closed.

@aymeric-roucher
Copy link
Collaborator

aymeric-roucher commented Jan 30, 2025 •
edited
Loading

Thank you @xianminx ! This part of the doc has moved to reference/models.md but I will do the change in another PR.

@albertvillanova
Copy link
Member

albertvillanova commented Jan 30, 2025 •
edited
Loading

The fix was already present in main: https://github.com/huggingface/smolagents/pull/254/files#diff-84ca4b65bf3ee57fb6d428691795589ebc90d42990a55bb26a2bb2e537297671L152-R154

@xianminx xianminx deleted the fix/doc branch February 5, 2025 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aymeric-roucher aymeric-roucher aymeric-roucher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xianminx @aymeric-roucher @albertvillanova