Improve openai server, add more examples of model with LiteLLM #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aymeric-roucher Hi. Please let me know if there is any problem with this PR. Should I close if it not needed. |
| **kwargs: | ||
| Additional keyword arguments to pass to the OpenAI API. | ||
| Additional optional arguments that will be passed directly to the | ||
| OpenAI API client, allowing for further customization. |
There was a problem hiding this comment.
Now we don't need any other parameters in the OpenAIServerModel than api_key and api_base! organization, project can be passed as kwargs by the user and temperature is already handled at the Model level
|
Thank you @duydl , sorry for the delay in getting back, this needed to wait for a refacto of parameters. Now we don't need additional parameters, when that's removed we can merge this PR! 😃 |
|
@duydl following up on the above, when you get a chace, please remove the additional parameters introduced and then we can merge the documentation improvements! 🤗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to add Azure API but realized it is supported with LiteLLM.
OpenAI model also are support by both LiteLLM and OpenAIServer class. For OpenAIServer class api_key and api_base are should be optional as they could be replaced with usage of env var.