-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ip-adapter] fix problem using embeds with the plus version of ip adapters #7189
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! The changes look very clean and simple to me. Thank you!
Should we maybe also add a small note about this support in the IP-Adapter guide? @yiyixuxu WDYT?
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Tested all the combinations I could think of with SDXL, the image isn't that nice but is faster to just use all three ip adapters at the same time ^^ Do the SD 1.5 versions have different dimensions? there's six of them. |
Could do a quick check on the checkpoints maybe? |
I did and it worked with almost all of them except this one:
This also reminded me that there's one with the big image encoder for the SDXL ones, so I tested it and it didn't work either:
but those errors are not related to this PR |
I see. I think that needs fixing then. Would you mind opening an issue for this and we can work on that in a separate PR? |
It was an obvious mistake on my part, since both of those use a different image encoder and I was using them in combination with the normal ones, that was the error, I can't mix the adapters that use different image encoders since we load one for all of them. They work as expected if I use them alone. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
What does this PR do?
Allows the use of 4D tensors to be able to pass embeds made with the IP Adapter PLUS versions
Fixes #7168
How to test:
Who can review?
@yiyixuxu @sayakpaul
Also cc: @fabiorigano because of #7186