Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dockerfiles] add: a workflow to check if docker containers can be built in case of modifications #7129

Merged
merged 19 commits into from
Mar 11, 2024

Conversation

sayakpaul
Copy link
Member

No description provided.

@sayakpaul sayakpaul requested a review from DN6 February 28, 2024 08:23
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@DN6
Copy link
Collaborator

DN6 commented Mar 4, 2024

What exactly would we be testing here? That the build completes?

@sayakpaul
Copy link
Member Author

Yeah.

@DN6
Copy link
Collaborator

DN6 commented Mar 4, 2024

Can't we just run the existing workflow? Or just update the docker build workflow to run on change? Why add another workflow?

@sayakpaul
Copy link
Member Author

sayakpaul commented Mar 4, 2024

Can't we just run the existing workflow?

Integrating a change after ensuring it successfully passes is what I would like to keep in mind here. We could have easily avoided the problem that warranted this PR then: #7155.

Or just update the docker build workflow to run on change? Why add another workflow?

I can look into this.

Copy link
Collaborator

@DN6 DN6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nicely done! 👍🏽

@sayakpaul
Copy link
Member Author

@DN6 turns out the workflow doesn't show up on the PR strangely, but you can see it here: https://github.com/huggingface/diffusers/actions/runs/8144706116/job/22259379215. I have also made the code simpler and a bit more explicit. So, would appreciate another review.

I explicitly changed a Dockerfile to test things out but will remove that change once you approve the PR.

@sayakpaul
Copy link
Member Author

@DN6 good to merge?

@sayakpaul sayakpaul merged commit 5dd8e04 into main Mar 11, 2024
11 checks passed
@sayakpaul sayakpaul deleted the docker-build-workflow branch March 11, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants