-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dockerfiles] add: a workflow to check if docker containers can be built in case of modifications #7129
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
What exactly would we be testing here? That the build completes? |
Yeah. |
Can't we just run the existing workflow? Or just update the docker build workflow to run on change? Why add another workflow? |
Integrating a change after ensuring it successfully passes is what I would like to keep in mind here. We could have easily avoided the problem that warranted this PR then: #7155.
I can look into this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nicely done! 👍🏽
@DN6 turns out the workflow doesn't show up on the PR strangely, but you can see it here: https://github.com/huggingface/diffusers/actions/runs/8144706116/job/22259379215. I have also made the code simpler and a bit more explicit. So, would appreciate another review. I explicitly changed a Dockerfile to test things out but will remove that change once you approve the PR. |
@DN6 good to merge? |
No description provided.