Add validation to sceDisplaySetFramebuf #8743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're just trying to detect frequent flips, so off/on doesn't play into it.
These are returned by sceDisplayGetFrameBuf().
It seems you must latch a change to stride/fmt first, which basically makes sense. Otherwise it would revert, I suppose.
This seems to be involved in using the video out cable, but fails for anything but these fixed parameters in normal situations.
|
Nice finds! |
|
FWIW, the only SetModes so far are all bogus values that should fail: Pangya did also hit the latch first issue: -[Unknown] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An interesting thing: per my tests, you can't set a new format or stride without latching it first. This might catch some curious scenarios where games change fb formats in a sequence that causes a blink or something.
Hoping this will help #8691. It might've been disabling the display in that way, for example. But I also realized we were max-60-fps'ing the display off/on, which it must've been doing each frame.
This passes the test in hrydgard/pspautotests#189.
-[Unknown]