Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PL] Update used jargon #2970

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

Dominoxan
Copy link
Contributor

Zmiany, literówki, gramatyka i inne.

Zmiany, literówki, gramatyka i inne.
@tetele tetele changed the title Update _common.yaml [PL] Update used jargon Feb 6, 2025
@Uriziel01
Copy link
Contributor

Ok, there is a lot to unpack here, so let's get started :)

I'm all about readability and proper translations, but at the same time we absolutely have to maintain consistent naming convention with the existing HA UI translations.

If entities are translated as Encje everywhere in the current UI available we HAVE to maintain that in the intents repository to avoid further confusion for the end user and to not make the learning curve ever steeper than it already is.
So although it might be more readable for you to call them Elementy rathen than Encje it would require you to change all the translations in the UI (and get an approval there for that matter), not only HA intents for assistant purposes. Same goes for Domeny <> Kategorie, Aktywujące <> Inicjujące and so on.

I'm more than happy to merge all the minor improvements, grammatical errors and so on if you adjust the pull request to reflect only these types of changes.

Sorry for the inconvenience if any.

@Dominoxan
Copy link
Contributor Author

I see the point. You are completely right, that would require to rebuild / re-translate entire UI. Can we leave it as it is for a while? I'm totally not familiar with Github workflows, I' struggling even with minor stuff. Let me investigate how to get rid of heavy cannons like "Encje" from my Pull and leave cosmetics only.

@witold-gren witold-gren marked this pull request as draft February 19, 2025 22:01
@witold-gren
Copy link
Contributor

Hey @Dominoxan, because you are still planning to work with this PR, I just transformed it into a draft. If you complete the changes, just recreate it to PR.

PS. Thanks a lot for finding this small bugs with typos, such changes are very helpful. 💪🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants