Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docs for Yandex TTS #7960

Merged
merged 1 commit into from
Dec 27, 2018

Conversation

gipnokote
Copy link
Contributor

Description:
Updated docs for Yandex TTS component.

Pull request in home-assistant (if applicable): home-assistant/core#19603

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@ghost ghost added the to-do label Dec 27, 2018
@gipnokote gipnokote changed the base branch from next to current December 27, 2018 16:50
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit feb7ffe into home-assistant:current Dec 27, 2018
@ghost ghost removed the to-do label Dec 27, 2018
@gipnokote gipnokote deleted the tts-yandex-patch-1 branch December 27, 2018 17:24
@frenck
Copy link
Member

frenck commented Dec 27, 2018

This PR should have been merged into next.

@frenck frenck added new-feature This PR adds documentation for a new Home Assistant feature to an existing integration current This PR goes into the current branch has-parent This PR has a parent PR in a other repo labels Dec 27, 2018
@gipnokote
Copy link
Contributor Author

I'm sorry, this was my first commit into HA repo, I was reading the dev docs and I wasn't completely sure into which branch I should commit. I decided that if the component already exists then current is the appropriate one. Could you please elaborate the logic how "next" is the proper one, so I know next time where to commit? And should I take any action now?

@frenck
Copy link
Member

frenck commented Dec 30, 2018

@gipnokote Sure! If the change matches the current release and thus the current documentation it goes into current. Changes to that branch will be visible live directly after the merge. If the change to the documentation depends on a next release (e.g., new components and features), it should go into the next branch. The next branch will be merged into current on the next Home Assistant release. Causing these change to be visible live on the next release.

alengwenus pushed a commit to alengwenus/home-assistant.io that referenced this pull request Feb 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current This PR goes into the current branch has-parent This PR has a parent PR in a other repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants