Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated set of available voices for Yandex TTS #19603

Merged
merged 1 commit into from
Dec 27, 2018

Conversation

gipnokote
Copy link
Contributor

Description:

As many new voices became available in Yandex TTS, I've added them to the HA component. I have tested the code and the voices, they work fine. The source of added voices list is their demo page: https://webasr.yandex.net/ttsdemo.html (you can see available voices when you inspect the select box which says "Oksana")

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@homeassistant

This comment has been minimized.

@ghost ghost added the in progress label Dec 27, 2018
@gipnokote
Copy link
Contributor Author

gipnokote commented Dec 27, 2018

I accidentally made a commit with a different email; I've amended the commit and put my primary email.
I've also just noticed I haven't made changes in the documentation. I will add the voices there.

@homeassistant

This comment has been minimized.

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit 4c59a65 into home-assistant:dev Dec 27, 2018
@ghost ghost removed the in progress label Dec 27, 2018
@gipnokote gipnokote deleted the tts-yandex-patch-1 branch December 27, 2018 17:24
@balloob balloob mentioned this pull request Jan 10, 2019
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed integration: tts small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants