-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capitalise ha-relative-time in state-display #21949
Conversation
This matches the capitalisation applied to hui-timestamp-display, and state-info displays
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
WalkthroughWalkthroughThe changes in this pull request involve the addition of a Changes
Assessment against linked issues
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review due to trivial changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Proposed change
This PR corrects inconsistent capitalisation for relative time displays. Currently capitalisation is applied to
ha-relative-time
when displayed in thestate-info
component, but not in thestate-display
component. Capitalisation is applied forhui-timestamp-display
instate-display
, however.This PR applies capitalisation for
ha-relative-time
fromstate-display
, removing this inconsistency.Type of change
Additional information
Checklist
Tests have been added to verify that the new code works.N/ASummary by CodeRabbit
capitalize
attribute to the<ha-relative-time>
component for improved visual presentation of time-related data.