Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aiohttp to 3.7.3 #42514

Closed
wants to merge 1 commit into from
Closed

Bump aiohttp to 3.7.3 #42514

wants to merge 1 commit into from

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 28, 2020

Proposed change

Currently blocked as zero byte file serving regressed again. Fixed in aio-libs/aiohttp#5380

Bump aiohttp to 3.7.3

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@bdraco
Copy link
Member Author

bdraco commented Oct 28, 2020

3.7.2 re-regressed 0 bytes files again.

@bdraco bdraco marked this pull request as draft October 28, 2020 15:28
@RobBie1221 RobBie1221 mentioned this pull request Nov 2, 2020
21 tasks
@frenck
Copy link
Member

frenck commented Nov 4, 2020

I've seen I opened the same PR. Any reason to block/draft?

@bdraco
Copy link
Member Author

bdraco commented Nov 4, 2020

aio-libs/aiohttp#5157 regressed aio-libs/aiohttp#5125. It looks like my test wasn't good enough to catch it.

@bdraco
Copy link
Member Author

bdraco commented Jan 21, 2021

Closing this since it was updated in #45180.

The zero byte file issue still exists, but I'm not sure its actually a problem. I've sent a PR upstream aio-libs/aiohttp#5380 and we can update again once its fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants