Fixed static files handling for loops without .sendfile() #5157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5157 +/- ##
==========================================
- Coverage 97.56% 97.56% -0.01%
==========================================
Files 43 43
Lines 8846 8781 -65
Branches 1420 1412 -8
==========================================
- Hits 8631 8567 -64
+ Misses 101 100 -1
Partials 114 114
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
asvetlov
approved these changes
Oct 27, 2020
21 tasks
bdraco
added a commit
to bdraco/aiohttp
that referenced
this pull request
Jan 2, 2021
Changing the sendfile implementation in aio-libs#5157 caused a regression with sending zero byte files, and the test had too much mocking to expose the issue.
5 tasks
bdraco
added a commit
to bdraco/aiohttp
that referenced
this pull request
Jan 2, 2021
Changing the sendfile implementation in aio-libs#5157 caused a regression with sending zero byte files, and the test had too much mocking to expose the issue.
bdraco
added a commit
to bdraco/aiohttp
that referenced
this pull request
Jan 2, 2021
Changing the sendfile implementation in aio-libs#5157 caused a regression with sending zero byte files, and the test had too much mocking to expose the issue.
bdraco
added a commit
to bdraco/aiohttp
that referenced
this pull request
Jan 2, 2021
Changing the sendfile implementation in aio-libs#5157 caused a regression with sending zero byte files, and the test had too much mocking to expose the issue.
commonism
pushed a commit
to commonism/aiohttp
that referenced
this pull request
Apr 27, 2021
commonism
pushed a commit
to commonism/aiohttp
that referenced
this pull request
Apr 27, 2021
asvetlov
pushed a commit
that referenced
this pull request
Oct 27, 2021
Changing the sendfile implementation in #5157 caused a regression with sending zero byte files, and the test had too much mocking to expose the issue.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Bug fix. Static routes on
aiohttp+uvloopnow work again.Are there changes in behavior for the user?
No.
Related issue number
Fixes #5149.
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.