Debug sfr_box diagnostic test

[emontnemery]

Proposed change

Debug sfr_box diagnostic test

The class added to sfr_box/__init__.py makes tests fail. Some extra checks added to sfr_box/conftest.py to narrow down the problem.

pytest -vvv tests/components/sfr_box/test_diagnostics.py

With this change, the test passes:

diff --git a/tests/components/sfr_box/__init__.py b/tests/components/sfr_box/__init__.py
index e4b86709536..cbc8ce5e17f 100644
--- a/tests/components/sfr_box/__init__.py
+++ b/tests/components/sfr_box/__init__.py
@@ -6,5 +6,5 @@ from typing import Optional, Union
 class StupidClass:
     """Blah."""

-    def __init__(self, connect_timeout: Optional[Union[int, float]]) -> None:  # noqa: UP007
-        """Blah."""
+    #def __init__(self, connect_timeout: Optional[Union[int, float]]) -> None:  # noqa: UP007
+    #    """Blah."""

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Ruff (ruff format homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @epenet, mind taking a look at this pull request as it has been labeled with an integration (sfr_box) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of sfr_box can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign sfr_box Removes the current integration label and assignees on the pull request, add the integration domain after the command.
• @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
• @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

[joostlek]

Fixed by hacf-fr/sfrbox-api#327

[emontnemery]

I want to understand how changing the typing fixes the problem instead of just closing the issue

[emontnemery]

The problem goes away if pydantic is downgraded from 1.10.17 to 1.10.16.

The diff is not large between those two releases, it seems to be mostly about shuffling 1.x-code around: pydantic/pydantic@v1.10.16...v1.10.17

Edit: Tests pass when removing the pydantic cython libraries

[emontnemery]

Closing, this is a known issue in pydantic: pydantic/pydantic#4519