Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typing issue #327

Closed
wants to merge 1 commit into from
Closed

Fix typing issue #327

wants to merge 1 commit into from

Conversation

joostlek
Copy link

No description provided.

@joostlek joostlek mentioned this pull request Sep 10, 2024
Closed
19 tasks
@emontnemery
Copy link

emontnemery commented Sep 10, 2024 •
edited
Loading

I don't like this fix without an explanation.
typing.Optional means the value may be None, now you shuffled things around a bit, writing out None instead of using Optional.
How does that robustly fix the issue seen in home-assistant/core#125679?

@epenet
Copy link
Collaborator

epenet commented Sep 11, 2024

I wonder if we even need "int".
Maybe float is enough...

@epenet
Copy link
Collaborator

epenet commented Sep 11, 2024

Note: I have dropped pydantic in #330

Currently releasing 0.0.11

@epenet
Copy link
Collaborator

epenet commented Sep 11, 2024

Closing, this is a known issue in pydantic: pydantic/pydantic#4519

@epenet epenet closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joostlek @emontnemery @epenet