Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure FileDownload button can be clicked anywhere #5431

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Ensure FileDownload button can be clicked anywhere #5431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions panel/dist/css/button.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,3 +136,10 @@
background-color: var(--light-bg-color);
color: black;
}

.bk-btn a {
Copy link
Collaborator

@MarcSkovMadsen MarcSkovMadsen Aug 24, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to remove the padding from the button. I.e. set it to 0px. Otherwise the button will get 12px higher than today.

I think you need to make this more specific targetting the FileDownload specifically ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@philippjfr

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't want to delete the padding from the general Button that is true, the .bk-btn a rule is fine because a regular Button doesn't support links inside it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did what you did here in beginning resulting in 12px too high button.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the padding on a needed at all?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was for me. It aligns the text center vertically. That is also why it was on the button in the first place.

display: inline-block;
height: 100%;
width: 100%;
padding: 6px;
}