Ensure FileDownload button can be clicked anywhere #5431
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5431 +/- ##
===========================================
- Coverage 83.30% 72.57% -10.73%
===========================================
Files 274 274
Lines 40005 40005
===========================================
- Hits 33325 29035 -4290
- Misses 6680 10970 +4290
Flags with carried forward coverage won't be shown. Click here to find out more. see 67 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -136,3 +136,10 @@ | |||
| background-color: var(--light-bg-color); | |||
| color: black; | |||
| } | |||
|
|
|||
| .bk-btn a { | |||
There was a problem hiding this comment.
You also need to remove the padding from the button. I.e. set it to 0px. Otherwise the button will get 12px higher than today.
I think you need to make this more specific targetting the FileDownload specifically ?
There was a problem hiding this comment.
Wouldn't want to delete the padding from the general Button that is true, the .bk-btn a rule is fine because a regular Button doesn't support links inside it.
There was a problem hiding this comment.
I did what you did here in beginning resulting in 12px too high button.
There was a problem hiding this comment.
Is the padding on a needed at all?
There was a problem hiding this comment.
It was for me. It aligns the text center vertically. That is also why it was on the button in the first place.
|
I find it is still possible to click a button without triggering the callback with panel 1.2.2 that includes this fix (although after this update, the "non-triggering area" is significantly smaller) Maybe this picture from chrome helps The HTML code with classes is <button type="bk_btn, bk_btn_type" class="bk-btn bk-btn-primary"><a>Download data.xlsx</a></button> |
Fixes #5425