feat: display PR Cycle Time info #179
Conversation
- fix: clear error message not displayed on UI.
|
@power-f-GOD is attempting to deploy a commit to the Holdex Accelerator Team on Vercel. To accomplish this, @power-f-GOD needs to request access to the Team. Afterwards, an owner of the Team is required to accept their membership request. If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account. |
| @@ -65,7 +65,7 @@ module.exports = { | |||
| ], | |||
| 'no-floating-decimal': 'warn', | |||
| 'no-implicit-coercion': [ | |||
| 'error', | |||
| 'off', | |||
There was a problem hiding this comment.
why?
Ok. I got tired of the linter converting my succinct !!<expression>s to Boolean(<expression>), and also TypeScript not being able to infer the truthiness of Boolean when used in a ternary check or similar.
E.g.
// errs
let a: Record<string, any> | null = { b: 1 };
let c = Boolean(a) ? a.b : 1; // TS-check (linter) error: `a` is possibly `null`
// doesn't err
let a: Record<string, any> | null = { b: 1 };
let c = !!a ? a.b : 1; // No errors|
@power-f-GOD is this ready for review or is it WIP? |
Yes, it is, but previous PRs have to be reviewed and merged first. This first: #175. Cc: @georgeciubotaru |
…st-in-usd--add-rate' into 127-problem-as-sponsor-i-cant-see-the-actual-feature-cost-in-usd--cost-breakdown
|
@power-f-GOD the previous PR was merged. What's next? |
Notice I said "PRs" not "PR". This is next: #176 Cc: @georgeciubotaru |
…st-in-usd--cost-breakdown' into 177-problem-manager-cant-see-pr-participants-at-first-glance
…st-in-usd--cost-breakdown' into 166-problem-i-cant-see-all-open-prs-per-by-developer-and-how-many-hours-ago-was-open--cycle-time
…lance' into 166-problem-i-cant-see-all-open-prs-per-by-developer-and-how-many-hours-ago-was-open--cycle-time
|
@georgeciubotaru , Please, merge #183 first before the current PR. |
|
@power-f-GOD Please resolve the conflicts |
|
Did you forget to use REQUEST REVIEW feature? |
I forgot this one time.😅 But that was because George got here before me after he merged the preceeding PR. |
Resolves: #166
TA:
3hrs(->4hrs)