Goal: management view (breakdown by developer)

[zolotokrylin]

Spec Document

Project Figma Design

Problems

Preview Give feedback

1. Problem: Holdex team is not using fork strategy with Ithaca project autoinvoice#195
   +0
   
2. Problem: Manager cannot tell from the PR of the contributor's bug-feature ratio #180
   +0
3. Problem: as sponsor I can't see the actual feature cost in USD autoinvoice#127
   4 of 4
   +0
4. Problem: I can't log in as manager (role) of this app autoinvoice#160
   api feature +2
5. Problem: I can't see all open PRs per by developer (and how many hours ago was open) autoinvoice#166
   1 of 2
   +0
6. Problem: Unauthorized entities [users] have access to the API endpoints, hence DB autoinvoice#161
   api blocked by feature +3
7. Problem: Manager can't see PR participants list autoinvoice#177
   feature +1
8. Problem: unable to track high level KPIs of team members autoinvoice#192
   3 of 4
   +0
   

[power-f-GOD]

@zolotokrylin , just to understand the context of this problem... Is it the same as being unable to submit a PR (cost details in hours), or is it a new feature entirely? If it is the latter, can you explain what you mean?

[zolotokrylin]

It is a new feature entirely. And it needs to go through the design stage first.
FYI @markcurchin

[zolotokrylin]

@power-f-GOD this issue was in NEW, and not in READY.

[zolotokrylin]

@markholdex we need design here please

[power-f-GOD]

@markholdex we need design here please

🤲🏼

And this is the next thing, yeah?

[markholdex]

log: I attached the spreadsheet document with the design representations. I started to create designs. Not complete. Hard to implement and work with existing components. Too much stuff is hardcoded and doesn't work as components at all. Will need more time than I planned.

[markholdex]

ETA 1,5 hrs here

[markholdex]

log: Designs attached for all use-cases.

[markholdex]

@zolotokrylin when you have time, have a look.

[power-f-GOD]

@markholdex , kindly grant me access to the doc.

[power-f-GOD]

While I wait for access, let me drop my questions/thoughts here.

• In the design, is the "Cycle Time" equivalent to this (in one of the PS) above: "...and how many hours ago was open", @markholdex ?

• Also, I think I'd rather have the "Approve" button on the right (of the card).🌚

• And I see that the button no longer exists on the PRs list screen. Do you like/prefer it like that, @zolotokrylin ? It means you have to go into every PR to be able to approve.

• Although, I'd advise/suggest that the table details exist on the PRs list, but hidden by default and shown on toggle of a button, 'cause I feel there isn't much happening there (for now) that demands a dedicated page for the same.

[markholdex]

@power-f-GOD

• cycle time is the time from when the PR was open. If the PR was closed, then it should also include the delta between open and close time.
• about the button on PR list, I'm also thinking to add it back.
• initially I thought to add the table on the list page, but the action is too heavy on the database side as it will need to join different tables for multiple times. So in order to keep it fast, I went with spectate page. Though we can make it under a button which will perform a dedicated request on click.

[power-f-GOD]

cycle time is the time from when the PR was open...

Hmm. Ok. Looking at the design again, it seems to imply the sum of all the time(s) spent by the contributors on the PR, i'n it?🤔

...If the PR was closed, then it should also include the delta between open and close time.

Did you mean "...then it should be the delta between open and close time"?

...Though we can make it under a button which will perform a dedicated request on click.

Yeah. What I thought too.✔️

[power-f-GOD]

BTW, for the costs (in USD), we'll need the hourly/weekly/monthly rate detail of each contributor:

Example:

interface ContributorSchema {
  ...
  agreement: 'monthly', // enum
  rate: 10000, // number
  ...
}

Cc: @markholdex , @zolotokrylin .

[markholdex]

BTW, for the costs (in USD), we'll need the hourly/weekly/monthly rate detail of each contributor:

Example:

interface ContributorSchema {
  ...
  agreement: 'monthly', // enum
  rate: 10000, // number
  ...
}

Cc: @markholdex , @zolotokrylin .

@power-f-GOD monthly is enough. The rest is just math formulas.

[power-f-GOD]

monthly is enough. The rest is just math formulas.

But the rate is still needed though to compute the actual cost.

[georgeciubotaru]

@power-f-GOD We will have the rate as a number, this rate is for 176 hours

[power-f-GOD]

@power-f-GOD We will have the rate as a number, this rate is for 176 hours

Ok. How to get this rate?

And it is 160 - 173 hours (per month), FWIW.

[markholdex]

log: designs updated. Have a look and let me know your thoughts. If any comments/questions, please leave in Figma. Let's not flood here.

cc: @zolotokrylin @georgeciubotaru @power-f-GOD

[zolotokrylin]

@markholdex @georgeciubotaru left comments for you in Figma

[power-f-GOD]

I left some comments on the Figma as well.

PS. @markholdex , seems you missed this:

...If the PR was closed, then it should also include the delta between open and close time.

Did you mean "...then it should be the delta between open and close time"?

Here.

[zolotokrylin]

@georgeciubotaru rid you tell Powerthatwe are pausing here with development? I can't see any log but I can see new messages from Power here.

[power-f-GOD]

[Log] FWIW, I've switched and I'm currently working on the Open Term Pools for ClearPool.📝

[zolotokrylin]

@power-f-GOD are we working on this issue? cc: @georgeciubotaru

[power-f-GOD]

Ok...Are we?🤔 I guess we aren't, since I was "unassigned".

[power-f-GOD]

[Log] FWIW...

[zolotokrylin]

@georgeciubotaru what's happening here (main...128-problem-pr-is-missing-cost-breakdown-by-developer)? Why:

1. there is no PR for this branch?
2. why it is not merged?
3. why are we investing in something we don't merge eventually?

DON'T allow this to happen. In the future, we are not paying for the work which is not merged.

[power-f-GOD]

This goal would have been achieved when #179 is merged.📝

[markholdex]

Putting this Goal on hold until we clarify things on our end.

[markholdex]

@zolotokrylin when you have time, have a read of the new spec. Scroll down the page. I'll do more iterations as we go.

[zolotokrylin]

Design and Wireframe links were moved into the Spec doc. Let's keep it there all the time.

[zolotokrylin]

@markholdex I have modified doc and left some notes inside it (see version history)
What's left regarding specs? Please lead the way here.

[markholdex]

I will review and update the doc. Need to add the functionalities that we discussed on our meeting about: Stalled PR and Wrong titles.

[zolotokrylin]

@markholdex Please start with just a simple list of problems. Let's see what problems we want to batch into the next release.
Your text is good, but it is more like an article explaining how we came to the point where we are now. I don't see it being actionable for devs at this moment.

[markholdex]

@zolotokrylin I made a few updates to the document and added the problem questions that we should aim to answer in our product. Also attached Data Spec in description here. Please have a look too.

[zolotokrylin]

@markholdex discussed in person. Please pass this issue for design to Angelica ASAP.

[zolotokrylin]

Also left you comment in the Spec doc. Thanks!