Problem: Only PR creators can submit costs for their PRs

[georgeciubotaru]

Tasks

Preview Give feedback

1. Problem: Contributors previous submissions are not synced autoinvoice#153
   api feature fix +3
2. Problem: No Submissions Collection autoinvoice#126
   api feature +2
3. Problem: Contributors cannot see PRs they don't own autoinvoice#130
   api feature new implementation +3
4. Problem: Unsubmitted and Submitted tabs display same data autoinvoice#133
   api fix ui +3
5. Problem: Contributors "Submitted" PRs tab displays all PRs instead of submitted autoinvoice#139
   feature fix new implementation +3
6. Problem: Contributors cannot "Submit" PR details/cost autoinvoice#146
   feature fix new implementation +3
7. Problem: Contributors cannot "Re-Submit" PR details/cost autoinvoice#151
   api feature fix new implementation ui +5
8. Problem: Virtual submission object/field strangely makes it to the database autoinvoice#158
   api type: bug +2

[power-f-GOD]

Sorry, can you explain this, @georgeciubotaru ?

[georgeciubotaru]

@power-f-GOD Please book a meeting in 30 minutes, and let's discuss about that

[power-f-GOD]

@power-f-GOD Please book a meeting in 30 minutes, and let's discuss about that

Ok. Please, send your booking website.😅🤲🏼

[georgeciubotaru]

@power-f-GOD Just create a call in Google Chat and send me the invitation

[power-f-GOD]

I think this is worth converting into a goal, what do you reckon @georgeciubotaru ?

[georgeciubotaru]

@power-f-GOD You can define sub-problems (tasks) for that problem and resolve into multiple PRs

[zolotokrylin]

@georgeciubotaru is the problem: Problem: only PR creator can submit the cost for that PR?

[georgeciubotaru]

@zolotokrylin Yes

[zolotokrylin]

@power-f-GOD what's ETA here? I can see you implementing other issues like resubmitting PRs, etc., but when this will done?

[power-f-GOD]

@zolotokrylin , the tasks in the current problem's task list are all done, so it's safe/valid to say this problem is solved.📝

[georgeciubotaru]

@power-f-GOD I'm checking now the production URL, and still cannot see all my PRs.
I see only the ones that I created as the owner

[georgeciubotaru]

@power-f-GOD One more issue
https://invoice.holdex.io/contributors/8217518

I'm seeing the submissions made by another contributor on the PRs that I contributed, instead of seeing only my submissions

[power-f-GOD]

@georgeciubotaru , FWIW, this PR, #156 , would have to be merged (to prod), BTW, for me to ascertain those issues still exist ('cause I took some time to test and fix some issues this morning).

[power-f-GOD]

Hi, @georgeciubotaru .

So, what's next?🤲🏼

Cc: @zolotokrylin

[georgeciubotaru]

@power-f-GOD Have you checked my reported issues?

[power-f-GOD]

@power-f-GOD Have you checked my reported issues?

Ok. Has main been redeployed since I merged the PR?

And can you make a submission for this PR: fix: Owners can see their old PRs., let me also check/confirm.

[georgeciubotaru]

@power-f-GOD Can we increase the MAX_DATA_CHUNK to 50?

[power-f-GOD]

@power-f-GOD Can we increase the MAX_DATA_CHUNK to 50?

😮Man?! That's quite a lot at once. 20 okay?

[georgeciubotaru]

@power-f-GOD Let's put 25.

Also, I cannot see #144 PR in my list

[power-f-GOD]

@power-f-GOD Let's put 25.

Ok. I think I see why you were requesting 50, because, for you, it would be a lot of contributions, hence the need for pagination (somewhat).

[power-f-GOD]

Also, I cannot see #144 PR in my list

Yeah, so it's because of the MAX_DATA_CHUNK. If I increase it to 25 you will still NOT see the PR.

I'll increase it to 50 for now, then revert it to 10 when pagination is implemented.
But for Submitted PRs, I'll max it at 20 (for now).

[georgeciubotaru]

@power-f-GOD Also please check that condition for unsubmitted tab, I think something is wrong here

[
  {
    $match: {
      merged: true,
      contributor_ids: {
        $in: [8217518]
      },
    }
  },
  {
    $lookup: {
      from: "submissions",
      localField: 'id',
      foreignField: 'item_id',
      as: 'submission'
    }
  },
  {
    $unwind: { path: '$submission', preserveNullAndEmptyArrays: true }
  },
  {
    $match: {
      submission: {$exists: false },
      'submission.owner_id': { $ne: '' },
      'submission.approval': { $ne: '' }
    }
  }
]

this last $match block should be placed in
$lookup => pipeline => [{$match}]

[power-f-GOD]

Also please check that condition for unsubmitted tab, I think something is wrong here

What did you notice?

PS. I already tested it yesterday and it works. Even now.

[georgeciubotaru]

@power-f-GOD Based on the aggregation I get 0 results in the unsubmitted tab, instead of having ~ 56.

[georgeciubotaru]

@power-f-GOD Also, I'm seeing some items with

I thought you've migrated the fields and removed the old ones

[power-f-GOD]

@power-f-GOD Based on the aggregation I get 0 results in the unsubmitted tab, instead of having ~ 56.

Can I see (post) your query?

Also, I'm seeing some items with

Strange. Having a look...

[georgeciubotaru]

@power-f-GOD You have the Aggregations tab in MongoDB Compass app

[power-f-GOD]

I thought you've migrated the fields and removed the old ones

Ah. I see the issue. The check I put for migrating only thru prod prevented it, and I was unable to the time. I'll re-run it.

[power-f-GOD]

@power-f-GOD You have the Aggregations tab in MongoDB Compass app

I need to see your query. That's how I can tell/check/confirm you're making the right query.

[power-f-GOD]

@power-f-GOD You have the Aggregations tab in MongoDB Compass app

I need to see your query. That's how I can tell/check/confirm you're making the right query.

Ok. I see the problem. Having a look...

[georgeciubotaru]

@power-f-GOD It's the one in the comment above #123 (comment)

[power-f-GOD]

This is done/solved, yeah, @georgeciubotaru ?
I want to (or will) mark it as resolved by #159 .