Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.7 (end-of-life) #97

Merged
merged 2 commits into from
Jun 28, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/run-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
python-version: ["3.11"]
os: [ubuntu-latest, windows-latest, macos-latest]
include:
- python-version: "3.7"
- python-version: "3.8"
os: ubuntu-latest
runs-on: ${{ matrix.os }}
defaults:
Expand Down
3 changes: 2 additions & 1 deletion CHANGES.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
# Changelog

## unreleased
## 2023.1.0 (unreleased)

- Better handling of server response errors.
- Drop support for Python 3.7. `openneuro-py` now requires Python 3.8 or newer.

## 2022.2.0

Expand Down
6 changes: 1 addition & 5 deletions openneuro/__init__.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,4 @@
try:
from importlib import metadata
except ImportError:
# Running on pre-3.8 Python; use importlib-metadata package
import importlib_metadata as metadata
from importlib import metadata

try:
__version__ = metadata.version("openneuro-py")
Expand Down
6 changes: 1 addition & 5 deletions openneuro/_download.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,7 @@
from pathlib import Path, PurePosixPath
import string
import json
from typing import Optional, Union
if sys.version_info >= (3, 8):
from typing import Literal
else:
from typing_extensions import Literal
from typing import Optional, Union, Literal

if sys.version_info >= (3, 9):
from collections.abc import Iterable, Generator
Expand Down
5 changes: 1 addition & 4 deletions openneuro/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,7 @@
import stat
import json
import getpass
if sys.version_info >= (3, 8):
from typing import TypedDict
else:
from typing_extensions import TypedDict
from typing import TypedDict

import appdirs
from tqdm.auto import tqdm
Expand Down
4 changes: 1 addition & 3 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name = "openneuro-py"
description = "A Python client for OpenNeuro."
readme = "README.md"
requires-python = ">=3.7"
requires-python = ">=3.8"
license = {file = "LICENSE"}
keywords = ["science", "neuroscience"]
authors = [
Expand All @@ -19,8 +19,6 @@ dependencies = [
"click",
"aiofiles",
"sgqlc",
"importlib-metadata; python_version < '3.8'",
"typing-extensions; python_version < '3.8'",
"appdirs",
]
dynamic = ["version"]
Expand Down