Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Python 3.7 (end-of-life) #97

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Drop support for Python 3.7 (end-of-life) #97

merged 2 commits into from
Jun 28, 2023

Conversation

hoechenberger
Copy link
Owner

No description provided.

@hoechenberger hoechenberger requested a review from larsoner June 28, 2023 07:28
@hoechenberger

This comment was marked as resolved.

Sign in to view
@hoechenberger hoechenberger marked this pull request as draft June 28, 2023 07:33
@hoechenberger hoechenberger removed the request for review from larsoner June 28, 2023 07:34
@hoechenberger hoechenberger requested a review from larsoner June 28, 2023 07:41
@hoechenberger hoechenberger marked this pull request as ready for review June 28, 2023 07:41
@larsoner
Copy link
Collaborator

I don't have permissions to adjust the test requriements so you'll have to merge (or give me admin perms) @hoechenberger

@hoechenberger
Copy link
Owner Author

@larsoner Thanks!

Since this is a personal repo, I cannot grant admin access to collaborators, unfortunately

@hoechenberger hoechenberger enabled auto-merge (squash) June 28, 2023 13:10
@larsoner
Copy link
Collaborator

Now it says:

Merging is blocked
The base branch does not allow updates. Learn more about protected branches.

I assume you need to click the "update branch" button, I can't :(

@hoechenberger hoechenberger merged commit ac3244b into main Jun 28, 2023
@hoechenberger hoechenberger deleted the py-38 branch June 28, 2023 13:14
@hoechenberger
Copy link
Owner Author

I had locked main, apparently this also disabled merging. Un-locked it again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsoner larsoner larsoner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoechenberger @larsoner