Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DDCE-4709 Upgrade RAS to Upscan #206

Merged
merged 4 commits into from
May 9, 2024
Merged

DDCE-4709 Upgrade RAS to Upscan #206

merged 4 commits into from
May 9, 2024

Conversation

zmdnoor
Copy link
Contributor

@zmdnoor zmdnoor commented Apr 8, 2024

No description provided.

@platops-pr-bot
Copy link

  • uk.gov.hmrc.sbt-auto-build can be updated to 3.21.0 in project/plugins.sbt
  • Config key auditing.enabled can be removed from conf/application.conf. This is already provided by Bootstrap
  • There is a bobby warning (builds will be prevented after 30 Nov 2024) - see the pr builder for details
  • There is a bobby warning (builds will be prevented after 31 May 2024) - see the pr builder for details

@platops-pr-bot
Copy link

  • Config key auditing.enabled can be removed from conf/application.conf. This is already provided by Bootstrap
  • uk.gov.hmrc.sbt-auto-build can be updated to 3.21.0 in project/plugins.sbt
  • There is a bobby warning (builds will be prevented after 30 Nov 2024) - see the pr builder for details
  • There is a bobby warning (builds will be prevented after 31 May 2024) - see the pr builder for details

MRBeresford
MRBeresford requested changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@MRBeresford MRBeresford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments, let me know if you want to go through them etc :)

app/uk/gov/hmrc/rasapi/models/CallbackData.scala Outdated Show resolved Hide resolved
app/uk/gov/hmrc/rasapi/connectors/UpscanConnector.scala Outdated Show resolved Hide resolved
app/uk/gov/hmrc/rasapi/controllers/FileProcessingController.scala Outdated Show resolved Hide resolved
app/uk/gov/hmrc/rasapi/models/CallbackData.scala Outdated Show resolved Hide resolved
app/uk/gov/hmrc/rasapi/models/CallbackData.scala Outdated Show resolved Hide resolved
app/uk/gov/hmrc/rasapi/services/FileProcessingService.scala Outdated Show resolved Hide resolved
@MRBeresford
Copy link
Contributor

MRBeresford commented Apr 9, 2024 •
edited
Loading

There is also this PR bot comment
uk.gov.hmrc.sbt-auto-build can be updated to 3.21.0 ...

@platops-pr-bot
Copy link

  • Config key auditing.enabled can be removed from conf/application.conf. This is already provided by Bootstrap
  • uk.gov.hmrc.sbt-auto-build can be updated to 3.21.0 in project/plugins.sbt
  • There is a bobby warning (builds will be prevented after 30 Nov 2024) - see the pr builder for details
  • There is a bobby warning (builds will be prevented after 31 May 2024) - see the pr builder for details

@platops-pr-bot
Copy link

  • Config key auditing.enabled can be removed from conf/application.conf. This is already provided by Bootstrap
  • uk.gov.hmrc.sbt-auto-build can be updated to 3.21.0 in project/plugins.sbt
  • There is a bobby warning (builds will be prevented after 30 Nov 2024) - see the pr builder for details
  • There is a bobby warning (builds will be prevented after 31 May 2024) - see the pr builder for details

@zmdnoor
Copy link
Contributor Author

zmdnoor commented Apr 26, 2024

Changes implemented, have a look and let me know :)

MRBeresford
MRBeresford approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@MRBeresford MRBeresford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zmdnoor zmdnoor merged commit 04151cf into main May 9, 2024
1 check passed
@zmdnoor zmdnoor deleted the DDCE-4709 branch May 9, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MRBeresford MRBeresford MRBeresford approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zmdnoor @platops-pr-bot @MRBeresford @slavvco