Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mint fungible test for modularized #10479

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

kselveliev
Copy link
Contributor

Description:
This PR fixes failing I mint FUNGIBLE token and get the total supply and balance.
Based on the contract method implementation for fungible we should not pass any metadata in the function parameter otherwise the call goes through erc720 intertace and fails the test. Now just passing empty metadata for fungible call.

Related issue(s):
Partially completes #10430

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Kristiyan Selveliev <kristiyan.selveliev@limechain.tech>
@kselveliev kselveliev added enhancement Type: New feature test Test infrastructure, automated tests required, etc modularizedEVM labels Feb 24, 2025
@kselveliev kselveliev added this to the 0.125.0 milestone Feb 24, 2025
@kselveliev kselveliev self-assigned this Feb 24, 2025
@kselveliev kselveliev marked this pull request as ready for review February 24, 2025 11:06
@kselveliev kselveliev requested a review from a team as a code owner February 24, 2025 11:06
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

see 1 file with indirect coverage changes

Signed-off-by: Kristiyan Selveliev <kristiyan.selveliev@limechain.tech>
Copy link
Contributor

@bilyana-gospodinova bilyana-gospodinova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit d76c025 into main Feb 24, 2025
32 checks passed
@steven-sheehy steven-sheehy deleted the 10430-fix-fungible-mint-for-modularized branch February 24, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature modularizedEVM test Test infrastructure, automated tests required, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants