Remove Chain Event Types #3 #3044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/chain-events/services/ChainEventsConsumer/ChainEventHandlers/migration.ts # packages/commonwealth/client/scripts/controllers/server/chain_entities.ts
# Conflicts: # packages/commonwealth/server/models/subscription.ts
# Conflicts: # packages/chain-events/services/ChainEventsConsumer/ChainEventHandlers/entityArchival.ts # packages/chain-events/services/ChainEventsConsumer/ChainEventHandlers/migration.ts # packages/chain-events/services/ChainEventsConsumer/ChainEventHandlers/notification.ts # packages/chain-events/services/ChainEventsConsumer/ChainEventHandlers/storage.ts # packages/chain-events/services/ChainEventsConsumer/republishMessages.ts # packages/chain-events/services/ChainSubscriber/util.ts # packages/chain-events/services/database/database.ts # packages/chain-events/services/database/models/chain_event.ts # packages/chain-events/services/database/models/chain_event_type.ts # packages/chain-events/src/interfaces.ts # packages/chain-events/test/integration/service-tests/chainEventsConsumer.test.ts # packages/common-common/src/rabbitmq/RabbitMQConfig.ts # packages/common-common/src/rabbitmq/rabbitMQController.ts # packages/common-common/src/rabbitmq/types/chainEventNotificationsCUD.ts # packages/common-common/src/rabbitmq/types/chainEventTypeCUD.ts # packages/common-common/src/rabbitmq/types/index.ts # packages/commonwealth/client/scripts/controllers/server/chain_entities.ts # packages/commonwealth/client/scripts/controllers/server/notifications.ts # packages/commonwealth/client/scripts/controllers/server/socket/chainEventsNs.ts # packages/commonwealth/client/scripts/models/ChainEvent.ts # packages/commonwealth/client/scripts/models/DashboardActivityNotification.ts # packages/commonwealth/client/scripts/models/Notification.ts # packages/commonwealth/client/scripts/state.ts # packages/commonwealth/server/CommonwealthConsumer/CommonwealthConsumer.ts # packages/commonwealth/server/CommonwealthConsumer/messageProcessors/chainEventTypeCUDQueue.ts # packages/commonwealth/server/models.ts # packages/commonwealth/server/models/chain_event_type.ts # packages/commonwealth/server/models/notification.ts # packages/commonwealth/server/models/subscription.ts # packages/commonwealth/server/routes/deleteChain.ts # packages/commonwealth/server/routes/getSubscribedChains.ts # packages/commonwealth/server/routes/subscription/createSubscription.ts # packages/commonwealth/server/scripts/enforceDataConsistency.ts # packages/commonwealth/server/socket/chainEventsNs.ts # packages/commonwealth/server/util/emitNotifications.ts # packages/commonwealth/test/integration/enforceDataConsistency.spec.ts # packages/commonwealth/test/systemTests/consumer.test.ts
# Conflicts: # packages/chain-events/services/ChainEventsConsumer/republishMessages.ts
|
Fixed conflict with Master. When is D-Day? Can we do this tomorrow? @timolegros @jnaviask |
I'm free tomorrow after 1 pm. Seems like there are some type errors following the merge of substrate removal so I will fix that tonight and deploy to frick + quick QA again. |
jnaviask
approved these changes
Mar 16, 2023
jnaviask
added a commit
that referenced
this pull request
Mar 16, 2023
jnaviask
added a commit
that referenced
this pull request
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Issue
Closes: #2949
Description of Changes
Test Plan
Deployment Plan
Other Considerations