-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating democracy module for Substrate PR #5294. #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnaviask
changed the title
[WIP] Updating democracy module for Substrate PR #5294.
Updating democracy module for Substrate PR #5294.
Apr 3, 2020
dillchen
added a commit
that referenced
this pull request
Jul 23, 2021
jnaviask
added a commit
that referenced
this pull request
Jul 15, 2022
…ash-4.17.19 Bump lodash from 4.17.15 to 4.17.19
3 tasks
jnaviask
added a commit
that referenced
this pull request
Mar 16, 2023
* from event-types client side * move chain + network to event -> working chain activity dashboard * switch ce commands to ts-node-dev * chain + network added to event in ChainEventConsumer * save * filter out non entity creation/completion events for notifications * remove EventTypeCUD RabbitMQ types + config + pub/sub calls * remove ChainEventType model * remove chain-event-type migration * CET model removal fixes * CW remove CET migration * CW remove CET model * CET removal migrations + model update * migration fixes * migration fixes * chain subscriptions + chain-event notification settings + subscribedChains * add full chain to createSubscription route result + fix UI * turn off sourceMap, use proper tsconfig when building ce, and fixed scraper imports * add type check to CI + fix type errors * add type check to CI + fix type errors + remove format in CE repo * set allowJs: false in tsconfig so sourceMap files don't interrupt ts-node * RabbitMQ merge fixes * Make CI lint only the changes in the branch rather than everything * fix tsconfig + run prettier * merge fixes * merge fixes * discoverReconnectRange fix * consumer erc20 notification handler bug fix * load-env-var fix * Procfile fix * master merge fixes * fix chain-event notifications * fix chain-event email notifications * format * format * CE css fix * remove subscriptions count for chain-events * fix getSubscribedChains call * notification settings page fixes + remove unnecessary logs * format * delete script * migration script fix * prettier format * publishCustomRabbitMQMessage.ts improvements * prettier format * more script improvements for testing/QA * add dump file to gitignore * 8 min local * 15 seconds local * add fkey from NR to Sub * format * eslint + format + .prettierignore update * Ensure CET Removal Backwards Compatibility. (#2765) * Use CE proxy for events too. * Ensure backwards compatibility for deployment + fix link to chain. * Prettier fixes. * Remove log. * fixed type errors * fix lint * fix lint * format * small logging fix * migration log improvement * ce procfile fix * add missing index to notif table * Subscriptions pkey + not null * fix type * test improved CE queries * Procfile fix * heroku test * heroku test 2 * cleaup --------- Co-authored-by: Jake Naviasky <jake@commonwealth.im> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Muon Shot <120686579+CowMuon@users.noreply.github.com>
jnaviask
added a commit
that referenced
this pull request
Mar 16, 2023
jnaviask
added a commit
that referenced
this pull request
Mar 16, 2023
6 tasks
Rotorsoft
added a commit
that referenced
this pull request
Aug 13, 2024
…eanup Schemas cleanup following model ADR #3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Substrate PR #5294 (paritytech/substrate#5294) brings many updates to the democracy module, which this PR aims to support.
Implementation TODO:
Support proxy system queriesSupport proxy system transactionsreap_vote
,unlock
)Review and make changes forInstant
as neededremark
always fails to execute.remark
always fails, butbalance.setBalance
works, so I'm considering this a success.UI fixes needed:
unlock
call, on Kusama), or else they'll remain illiquid forever.Motivation and Context
Kusama runs off a more bleeding-edge version of Substrate than Edgeware, and we want to support Kusama, so this set of changes is designed to get Kusama back online.
How Has This Been Tested?
Code builds, and basic view tests. QA on local Kusama and local Edgeware chains. Query-only QA on live Kusama and live Edgeware chains.
Replication steps (Kusama):
./target/release/substrate --alice --chain=dev --force-authoring --validator
.edgeware-local
NodeInfo withkusama-local
in the database (either manually or by resetting).http://localhost:8080/kusama-local/
. Verify the console printsKUSAMA started.
.5GrwvaEF5zXb26Fz9rcQpDWS57CtERHpNehXCPcNoHGKutQY
) via subkey (use "//Alice" on command line).unvote
and setting a vote quantity become important. Also, if you chose to register the preimage and then pass the proposal, you'll note in the execution event that the function call fails. The reason for this remains unclear to me.Repeat this process with a local Edgeware node rather than Kusama to verify the changes are non-breaking.
Types of changes
Checklist: